-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow experiments table to sort by last run started #2890
Allow experiments table to sort by last run started #2890
Conversation
Is blocked by RHOAIENG-7692 |
51ca864
to
7714259
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2890 +/- ##
==========================================
+ Coverage 78.63% 78.65% +0.01%
==========================================
Files 1120 1120
Lines 23772 23778 +6
Branches 5984 5986 +2
==========================================
+ Hits 18693 18702 +9
+ Misses 5079 5076 -3
... and 3 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
I've included the Till the backend PR is merged, Last run started column will only show "Just now". |
7714259
to
cb95e12
Compare
@Gkrumbach07 should we mark on this on hold, till opendatahub-io/data-science-pipelines#52 merges? |
@dpanshug Looks like it merged. i am testing this with the changes |
frontend/src/concepts/pipelines/content/tables/experiment/renderUtils.tsx
Outdated
Show resolved
Hide resolved
tested and works. there is one thing we may or may not need to handle. the backend will return |
OK update from backend. Lets render |
cb95e12
to
dafa951
Compare
dafa951
to
56108da
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome thanks
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Gkrumbach07 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Closes: RHOAIENG-7715
Description
Added new column in Experiments table for last run started.
How Has This Been Tested?
Go to Experiments page and you can find the new column added.
Test Impact
Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
main
@yannnz