Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cookie): Bump tough-cookie using override #2889

Merged
merged 1 commit into from
Jun 10, 2024

Conversation

dgutride
Copy link
Contributor

@dgutride dgutride commented Jun 7, 2024

Description

Small set of changes to get tough-cookie override fixed: https://issues.redhat.com/browse/RHOAIENG-7540

How Has This Been Tested?

Ran/built locally - no errors

Test Impact

Shouldn't be any - either this will work or it won't

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Commits have been squashed into descriptive, self-contained units of work (e.g. 'WIP' and 'Implements feedback' style messages have been removed)
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change (find relevant UX in the SMEs section).

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress This PR is in WIP state label Jun 7, 2024
Copy link
Contributor

openshift-ci bot commented Jun 7, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-merge-robot openshift-merge-robot added the needs-rebase PR needs to be rebased label Jun 7, 2024
@openshift-merge-robot openshift-merge-robot removed the needs-rebase PR needs to be rebased label Jun 7, 2024
@dgutride
Copy link
Contributor Author

dgutride commented Jun 7, 2024

/test all

Copy link

codecov bot commented Jun 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.75%. Comparing base (34187a9) to head (3d0b283).
Report is 4 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2889   +/-   ##
=======================================
  Coverage   78.74%   78.75%           
=======================================
  Files        1116     1116           
  Lines       23717    23717           
  Branches     5972     5972           
=======================================
+ Hits        18677    18678    +1     
+ Misses       5040     5039    -1     

see 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 34187a9...3d0b283. Read the comment docs.

@dgutride dgutride marked this pull request as ready for review June 7, 2024 17:41
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress This PR is in WIP state label Jun 7, 2024
@openshift-ci openshift-ci bot requested review from Gkrumbach07 and mturley June 7, 2024 17:41
Copy link
Contributor

@lucferbux lucferbux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Run locally and built in and execute, it seems to work as expected.

Copy link
Contributor

openshift-ci bot commented Jun 10, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lucferbux

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 68a6f02 into opendatahub-io:main Jun 10, 2024
8 checks passed
@lucferbux lucferbux mentioned this pull request Jun 12, 2024
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants