-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(cookie): Bump tough-cookie using override #2889
fix(cookie): Bump tough-cookie using override #2889
Conversation
Skipping CI for Draft Pull Request. |
/test all |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2889 +/- ##
=======================================
Coverage 78.74% 78.75%
=======================================
Files 1116 1116
Lines 23717 23717
Branches 5972 5972
=======================================
+ Hits 18677 18678 +1
+ Misses 5040 5039 -1 see 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Run locally and built in and execute, it seems to work as expected.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lucferbux The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
Small set of changes to get tough-cookie override fixed: https://issues.redhat.com/browse/RHOAIENG-7540
How Has This Been Tested?
Ran/built locally - no errors
Test Impact
Shouldn't be any - either this will work or it won't
Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
main