Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RHOAIENG-7481] Add metrics columns to pipeline run table and modal param selector #2888

Conversation

jpuzz0
Copy link
Contributor

@jpuzz0 jpuzz0 commented Jun 7, 2024

Closes: RHOAIENG-7481

Description

Added action & modal to allow for metric related columns to be added to the pipeline runs table. The metric columns are added to local storage and unique for each experiment. The columns are re-orderable within the new modal.

image image

When on a page that has no runs with metrics belonging to previously selected custom columns:
image

When max amount of columns are selected:
image

When metrics don't match between runs:
image

Recently added typeahead search for metric names
image

(cc @yannnz)

How Has This Been Tested?

Unit tests

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Commits have been squashed into descriptive, self-contained units of work (e.g. 'WIP' and 'Implements feedback' style messages have been removed)
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change (find relevant UX in the SMEs section).

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress This PR is in WIP state label Jun 7, 2024
@openshift-merge-robot openshift-merge-robot added the needs-rebase PR needs to be rebased label Jun 7, 2024
@jpuzz0 jpuzz0 force-pushed the RHOAIENG-7481-metrics-columns-modal-selector branch from 5571547 to 8040fe6 Compare June 7, 2024 13:31
@openshift-merge-robot openshift-merge-robot removed the needs-rebase PR needs to be rebased label Jun 7, 2024
@jpuzz0 jpuzz0 force-pushed the RHOAIENG-7481-metrics-columns-modal-selector branch from 8040fe6 to 6443c3c Compare June 7, 2024 13:34
Copy link

codecov bot commented Jun 7, 2024

Codecov Report

Attention: Patch coverage is 54.81928% with 75 lines in your changes missing coverage. Please review.

Project coverage is 78.47%. Comparing base (ed9f7e4) to head (71b2631).
Report is 8 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2888      +/-   ##
==========================================
- Coverage   78.64%   78.47%   -0.18%     
==========================================
  Files        1120     1127       +7     
  Lines       23758    23917     +159     
  Branches     5979     6027      +48     
==========================================
+ Hits        18685    18768      +83     
- Misses       5073     5149      +76     
Files Coverage Δ
frontend/src/components/table/CheckboxTd.tsx 100.00% <100.00%> (ø)
frontend/src/components/table/TableBase.tsx 97.97% <100.00%> (+0.06%) ⬆️
...s/pipelines/apiHooks/mlmd/useGetArtifactsByRuns.ts 100.00% <100.00%> (ø)
...ls/pipelineRun/artifacts/ArtifactVisualization.tsx 48.21% <100.00%> (+4.66%) ⬆️
...content/tables/pipelineRun/PipelineRunTableRow.tsx 93.18% <100.00%> (+0.68%) ⬆️
...content/tables/pipelineRun/useMetricColumnNames.ts 100.00% <100.00%> (ø)
...epts/pipelines/content/tables/pipelineRun/utils.ts 100.00% <100.00%> (ø)
...nt/pipelinesDetails/pipelineRun/artifacts/utils.ts 87.50% <87.50%> (ø)
...tent/tables/pipelineRun/UnavailableMetricValue.tsx 50.00% <50.00%> (ø)
...d/src/concepts/pipelines/content/tables/columns.ts 53.84% <50.00%> (-1.71%) ⬇️
... and 3 more

... and 9 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed9f7e4...71b2631. Read the comment docs.

@jpuzz0 jpuzz0 force-pushed the RHOAIENG-7481-metrics-columns-modal-selector branch from 6443c3c to d12cae5 Compare June 7, 2024 16:06
@openshift-merge-robot openshift-merge-robot added the needs-rebase PR needs to be rebased label Jun 7, 2024
@jpuzz0 jpuzz0 force-pushed the RHOAIENG-7481-metrics-columns-modal-selector branch from d12cae5 to 507d161 Compare June 7, 2024 16:08
@openshift-merge-robot openshift-merge-robot removed the needs-rebase PR needs to be rebased label Jun 7, 2024
@jpuzz0 jpuzz0 force-pushed the RHOAIENG-7481-metrics-columns-modal-selector branch 4 times, most recently from deacc85 to 5da72a2 Compare June 7, 2024 18:23
@Gkrumbach07
Copy link
Member

I wonder if we want a max height on this modal. it maxes out pretty quickly
Screenshot 2024-06-07 at 1 59 37 PM

@jpuzz0 jpuzz0 force-pushed the RHOAIENG-7481-metrics-columns-modal-selector branch from 5da72a2 to 049be11 Compare June 7, 2024 19:27
@jpuzz0
Copy link
Contributor Author

jpuzz0 commented Jun 7, 2024

I wonder if we want a max height on this modal. it maxes out pretty quickly ![Screenshot 2024-06-07 at 1 59 37 PM]

@Gkrumbach07 I agree that is probably a bit too tall. I added a set content height of 500px for the body of the Modal. Let me know if you'd like it to be something different.

@jpuzz0 jpuzz0 force-pushed the RHOAIENG-7481-metrics-columns-modal-selector branch 3 times, most recently from 1391bbd to 14555bf Compare June 10, 2024 15:13
@jpuzz0 jpuzz0 changed the title WIP [RHOAIENG-7481] Add metrics columns to pipeline run table and modal param selector [RHOAIENG-7481] Add metrics columns to pipeline run table and modal param selector Jun 10, 2024
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress This PR is in WIP state label Jun 10, 2024
@jpuzz0 jpuzz0 force-pushed the RHOAIENG-7481-metrics-columns-modal-selector branch 2 times, most recently from 996b96c to 3331cd3 Compare June 10, 2024 16:13
@jpuzz0 jpuzz0 requested a review from yannnz June 10, 2024 16:13
@jpuzz0 jpuzz0 force-pushed the RHOAIENG-7481-metrics-columns-modal-selector branch from 3331cd3 to 7f2a989 Compare June 11, 2024 17:13
@jpuzz0 jpuzz0 force-pushed the RHOAIENG-7481-metrics-columns-modal-selector branch 2 times, most recently from 13f4fb4 to beb592f Compare June 11, 2024 19:10
@jpuzz0 jpuzz0 force-pushed the RHOAIENG-7481-metrics-columns-modal-selector branch from beb592f to 71b2631 Compare June 11, 2024 19:25
@Gkrumbach07
Copy link
Member

/lgtm
/approve

tested and this works.

Copy link
Contributor

openshift-ci bot commented Jun 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Gkrumbach07

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit c720c3c into opendatahub-io:main Jun 12, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants