-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RHOAIENG-7481] Add metrics columns to pipeline run table and modal param selector #2888
[RHOAIENG-7481] Add metrics columns to pipeline run table and modal param selector #2888
Conversation
5571547
to
8040fe6
Compare
8040fe6
to
6443c3c
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2888 +/- ##
==========================================
- Coverage 78.64% 78.47% -0.18%
==========================================
Files 1120 1127 +7
Lines 23758 23917 +159
Branches 5979 6027 +48
==========================================
+ Hits 18685 18768 +83
- Misses 5073 5149 +76
... and 9 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
6443c3c
to
d12cae5
Compare
d12cae5
to
507d161
Compare
deacc85
to
5da72a2
Compare
5da72a2
to
049be11
Compare
@Gkrumbach07 I agree that is probably a bit too tall. I added a set content height of 500px for the body of the Modal. Let me know if you'd like it to be something different. |
frontend/src/concepts/pipelines/content/tables/pipelineRun/PipelineRunTable.tsx
Outdated
Show resolved
Hide resolved
frontend/src/concepts/pipelines/content/tables/pipelineRun/CustomMetricsColumnsModal.tsx
Outdated
Show resolved
Hide resolved
frontend/src/concepts/pipelines/content/tables/pipelineRun/PipelineRunTable.tsx
Show resolved
Hide resolved
1391bbd
to
14555bf
Compare
996b96c
to
3331cd3
Compare
frontend/src/concepts/pipelines/content/tables/pipelineRun/PipelineRunTable.tsx
Show resolved
Hide resolved
3331cd3
to
7f2a989
Compare
13f4fb4
to
beb592f
Compare
beb592f
to
71b2631
Compare
/lgtm tested and this works. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Gkrumbach07 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Closes: RHOAIENG-7481
Description
Added action & modal to allow for metric related columns to be added to the pipeline runs table. The metric columns are added to local storage and unique for each experiment. The columns are re-orderable within the new modal.
When on a page that has no runs with metrics belonging to previously selected custom columns:
When max amount of columns are selected:
When metrics don't match between runs:
Recently added typeahead search for metric names
(cc @yannnz)
How Has This Been Tested?
Unit tests
Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
main