-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show correct artifact run node details on artifact side drawer panel #2885
Show correct artifact run node details on artifact side drawer panel #2885
Conversation
@DaoDaoNoCode I think Yan wants artifact nodes to be green if they exist and then grey otherwise see this mock: https://www.figma.com/design/etbN0ccCcZR1qKCpJXQNAg/Pipeline-phase-2?node-id=1585-97434&t=BZENynAkmHo29x6Z-0 |
d3b9012
to
c5e0106
Compare
@Gkrumbach07 Updated PR based on the mockup |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2885 +/- ##
=======================================
Coverage 78.74% 78.74%
=======================================
Files 1116 1116
Lines 23717 23717
Branches 5972 5972
=======================================
Hits 18677 18677
Misses 5040 5040
... and 4 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
works fine just one comment
c5e0106
to
7d27150
Compare
This looks good. we just need one more reviewer to merge /lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM @DaoDaoNoCode , tested in UI and against KF - artifact panel renders data as expected.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Gkrumbach07, jenny-s51 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
JIRA: https://issues.redhat.com/browse/RHOAIENG-7544
Description
Updated the way we search for the artifact details for a specific node. Also, I removed the status for the artifact node because an artifact node shouldn't have status. (I checked that in KF UI)
How Has This Been Tested?
Test Impact
N/A, it's topology side panel details change, hard to write test.
Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
main