Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show correct artifact run node details on artifact side drawer panel #2885

Merged

Conversation

DaoDaoNoCode
Copy link
Member

@DaoDaoNoCode DaoDaoNoCode commented Jun 6, 2024

JIRA: https://issues.redhat.com/browse/RHOAIENG-7544

Description

Updated the way we search for the artifact details for a specific node. Also, I removed the status for the artifact node because an artifact node shouldn't have status. (I checked that in KF UI)

Screenshot 2024-06-06 at 3 22 58 PM

How Has This Been Tested?

  1. Import the pipeline listed in the JIRA ticket
  2. Create a run using that pipeline
  3. Compare the artifact details with the KF UI to make sure the info is correct

Test Impact

N/A, it's topology side panel details change, hard to write test.

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Commits have been squashed into descriptive, self-contained units of work (e.g. 'WIP' and 'Implements feedback' style messages have been removed)
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change (find relevant UX in the SMEs section).

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

@DaoDaoNoCode DaoDaoNoCode requested a review from Gkrumbach07 June 6, 2024 19:26
@openshift-ci openshift-ci bot requested review from lucferbux and pnaik1 June 6, 2024 19:26
@Gkrumbach07
Copy link
Member

@DaoDaoNoCode I think Yan wants artifact nodes to be green if they exist and then grey otherwise

see this mock: https://www.figma.com/design/etbN0ccCcZR1qKCpJXQNAg/Pipeline-phase-2?node-id=1585-97434&t=BZENynAkmHo29x6Z-0

@DaoDaoNoCode
Copy link
Member Author

@Gkrumbach07 Updated PR based on the mockup

Copy link

codecov bot commented Jun 7, 2024

Codecov Report

Attention: Patch coverage is 73.33333% with 4 lines in your changes missing coverage. Please review.

Project coverage is 78.74%. Comparing base (34187a9) to head (7d27150).
Report is 10 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2885   +/-   ##
=======================================
  Coverage   78.74%   78.74%           
=======================================
  Files        1116     1116           
  Lines       23717    23717           
  Branches     5972     5972           
=======================================
  Hits        18677    18677           
  Misses       5040     5040           
Files Coverage Δ
frontend/src/concepts/topology/utils.ts 93.75% <100.00%> (+0.41%) ⬆️
...pts/pipelines/topology/usePipelineTaskTopology.tsx 90.42% <71.42%> (+2.00%) ⬆️

... and 4 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 34187a9...7d27150. Read the comment docs.

Copy link
Member

@Gkrumbach07 Gkrumbach07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works fine just one comment

frontend/src/concepts/topology/utils.ts Outdated Show resolved Hide resolved
@Gkrumbach07
Copy link
Member

This looks good. we just need one more reviewer to merge

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jun 7, 2024
@jenny-s51 jenny-s51 self-requested a review June 10, 2024 13:45
Copy link
Contributor

@jenny-s51 jenny-s51 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @DaoDaoNoCode , tested in UI and against KF - artifact panel renders data as expected.

Copy link
Member

@Gkrumbach07 Gkrumbach07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Copy link
Contributor

openshift-ci bot commented Jun 11, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Gkrumbach07, jenny-s51

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit bc28f39 into opendatahub-io:main Jun 11, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants