-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update mlmd service prefix #2877
update mlmd service prefix #2877
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Port-forwarding works as expected and executions table renders without error page.
@Gkrumbach07 please update the
|
/approve thanks for the reviews yall! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: DaoDaoNoCode, Gkrumbach07, jenny-s51 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold adding makefile change quick |
5687615
to
054549e
Compare
New changes are detected. LGTM label has been removed. |
Adding the labels back to get this to merge for nightlies. Actual changes were reviewed, however i needed to update the makefile as well so lgtm was lost /unhold |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2877 +/- ##
==========================================
+ Coverage 78.16% 78.18% +0.02%
==========================================
Files 1101 1101
Lines 23421 23438 +17
Branches 5902 5907 +5
==========================================
+ Hits 18307 18326 +19
+ Misses 5114 5112 -2 see 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
closes: https://issues.redhat.com/browse/RHOAIENG-7526
Description
Updated the pod name prefix for mlmd due to a backend change.
How Has This Been Tested?
There was an issue loading executions. Unknown Content-type received.
Test Impact
no tests impacted, backend change
Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
main