Dead code removal

[rsun19]

Closes: RHOAIENG-2497

Description

Changed code based on feedback from the google doc linked on this ticket.

How Has This Been Tested?

npm run test

Request review criteria:

Self checklist (all need to be checked):

• The developer has manually tested the changes and verified that the changes work
• Commits have been squashed into descriptive, self-contained units of work (e.g. 'WIP' and 'Implements feedback' style messages have been removed)
• Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
• The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

After the PR is posted & before it merges:

• The developer has tested their solution on a cluster by using the image produced by the PR to main

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.04%. Comparing base (2dc72ad) to head (c12ba9f).
Report is 32 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2862      +/-   ##
==========================================
+ Coverage   77.49%   78.04%   +0.54%     
==========================================
  Files        1109     1094      -15     
  Lines       23394    23246     -148     
  Branches     5890     5874      -16     
==========================================
+ Hits        18129    18142      +13     
+ Misses       5265     5104     -161     

Files	Coverage Δ
frontend/src/api/k8s/dashboardConfig.ts	90.00% <ø> (+3.04%)	⬆️
frontend/src/api/k8s/projects.ts	97.43% <ø> (-0.53%)	⬇️
frontend/src/api/k8s/pvcs.ts	100.00% <ø> (+6.25%)	⬆️
frontend/src/api/k8s/roleBindings.ts	96.55% <ø> (+4.65%)	⬆️
frontend/src/api/modelRegistry/k8s.ts	100.00% <ø> (+20.00%)	⬆️
frontend/src/concepts/design/utils.ts	87.06% <ø> (+15.23%)	⬆️
...rc/concepts/pipelines/apiHooks/usePipelineQuery.ts	100.00% <ø> (ø)
frontend/src/concepts/pipelines/const.ts	100.00% <ø> (ø)
...tifacts/charts/confusionMatrix/ConfusionMatrix.tsx	75.00% <ø> (ø)
...nes/content/pipelineSelector/useCreateSelectors.ts	95.00% <ø> (+18.07%)	⬆️
... and 17 more

... and 25 files with indirect coverage changes

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2dc72ad...c12ba9f. Read the comment docs.

[rsun19]

@christianvogt Up to date with confirmed changes/deletions

[christianvogt]

Can you not simply use the function as is?

Suggested change

	(secret): secret is AWSSecretKind => isSecretAWSSecretKind(secret), // note, always true is fine for now
	isSecretAWSSecretKind

[christianvogt]

/lgtm
/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: christianvogt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• frontend/OWNERS [christianvogt]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment