Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pipeline task node details link to execution #2858

Merged
merged 1 commit into from
Jun 3, 2024

Conversation

dpanshug
Copy link
Contributor

Closes: RHOAIENG-7545

Description

Added link to execution details page in the right drawer inside Input/Output tab.

Screencast.from.2024-05-29.20-46-10.mp4

How Has This Been Tested?

Create a run or expirement, and click on one of the node to find the Execution name in the right drawer inside Input/Output tab.
Clicking on the execution name will take you to the node details page.

Test Impact

Added unit test.

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Commits have been squashed into descriptive, self-contained units of work (e.g. 'WIP' and 'Implements feedback' style messages have been removed)
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change (find relevant UX in the SMEs section).

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

@yannnz

@openshift-ci openshift-ci bot requested review from Gkrumbach07 and mturley May 29, 2024 15:25
@dpanshug dpanshug force-pushed the execution-name branch 2 times, most recently from ce7d340 to fb475f7 Compare May 29, 2024 18:57
Copy link

codecov bot commented May 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.08%. Comparing base (197b42d) to head (591e52a).
Report is 30 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2858      +/-   ##
==========================================
+ Coverage   77.50%   78.08%   +0.58%     
==========================================
  Files        1110     1094      -16     
  Lines       23482    23256     -226     
  Branches     5917     5879      -38     
==========================================
- Hits        18199    18160      -39     
+ Misses       5283     5096     -187     
Files Coverage Δ
...Details/pipelineRun/SelectedNodeInputOutputTab.tsx 93.54% <100.00%> (+1.24%) ⬆️

... and 54 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 073cb0e...591e52a. Read the comment docs.

@dpanshug dpanshug force-pushed the execution-name branch 4 times, most recently from 2b44d78 to 41fe2f1 Compare May 30, 2024 13:12
@dpanshug dpanshug requested a review from Gkrumbach07 May 30, 2024 14:45
Copy link
Member

@Gkrumbach07 Gkrumbach07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm label Jun 3, 2024
Copy link
Contributor

openshift-ci bot commented Jun 3, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Gkrumbach07

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Jun 3, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 1127b46 into opendatahub-io:main Jun 3, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants