-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Microcopy for pipelines v2 #2842
Microcopy for pipelines v2 #2842
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2842 +/- ##
==========================================
- Coverage 77.42% 77.41% -0.01%
==========================================
Files 1102 1102
Lines 23200 23206 +6
Branches 5852 5856 +4
==========================================
+ Hits 17963 17966 +3
- Misses 5237 5240 +3
... and 7 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
frontend/src/__tests__/cypress/cypress/pages/pipelines/pipelineFilterBar.ts
Outdated
Show resolved
Hide resolved
ba8cedb
to
0077ff1
Compare
@jpuzz0 Made required updates and ready for reviewed again. |
this looks good. tested without the flag enabled and core flows work still /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Gkrumbach07 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
0f5a1c4
to
360eabe
Compare
JIRA: https://issues.redhat.com/browse/RHOAIENG-4985
Description
Compare the mockups and update the UI based on the microcopy doc:
https://docs.google.com/document/d/11SquEHVcyMVtuejCZxgAnFoY43GagYjQBhbfaI17Pn0/edit#heading=h.494mjlxa7qlu
How Has This Been Tested?
Compare the content in the doc with the UI, and make sure the suggested changes are addressed.
Test Impact
Updated some cypress test cases based on the UI updates.
Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
main