Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Microcopy for pipelines v2 #2842

Merged

Conversation

DaoDaoNoCode
Copy link
Member

@DaoDaoNoCode DaoDaoNoCode commented May 22, 2024

JIRA: https://issues.redhat.com/browse/RHOAIENG-4985

Description

Compare the mockups and update the UI based on the microcopy doc:
https://docs.google.com/document/d/11SquEHVcyMVtuejCZxgAnFoY43GagYjQBhbfaI17Pn0/edit#heading=h.494mjlxa7qlu

How Has This Been Tested?

Compare the content in the doc with the UI, and make sure the suggested changes are addressed.

Test Impact

Updated some cypress test cases based on the UI updates.

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Commits have been squashed into descriptive, self-contained units of work (e.g. 'WIP' and 'Implements feedback' style messages have been removed)
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change (find relevant UX in the SMEs section).

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

@openshift-ci openshift-ci bot requested review from alexcreasy and pnaik1 May 22, 2024 21:03
Copy link

codecov bot commented May 22, 2024

Codecov Report

Attention: Patch coverage is 97.91667% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 77.41%. Comparing base (9584b5e) to head (360eabe).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2842      +/-   ##
==========================================
- Coverage   77.42%   77.41%   -0.01%     
==========================================
  Files        1102     1102              
  Lines       23200    23206       +6     
  Branches     5852     5856       +4     
==========================================
+ Hits        17963    17966       +3     
- Misses       5237     5240       +3     
Files Coverage Δ
...epts/pipelines/content/DeletePipelineRunsModal.tsx 88.23% <100.00%> (ø)
...compareRuns/metricsSection/roc/RocCurveCompare.tsx 37.14% <ø> (ø)
...cepts/pipelines/content/createRun/CloneRunPage.tsx 100.00% <100.00%> (ø)
...epts/pipelines/content/createRun/CreateRunPage.tsx 100.00% <100.00%> (ø)
...c/concepts/pipelines/content/createRun/RunForm.tsx 96.29% <100.00%> (-0.38%) ⬇️
...c/concepts/pipelines/content/createRun/RunPage.tsx 100.00% <100.00%> (ø)
...epts/pipelines/content/createRun/RunPageFooter.tsx 73.52% <100.00%> (ø)
.../src/concepts/pipelines/content/createRun/const.ts 100.00% <100.00%> (ø)
...un/contentSections/ParamsSection/ParamsSection.tsx 100.00% <ø> (ø)
...ntent/createRun/contentSections/RunTypeSection.tsx 92.85% <100.00%> (-1.27%) ⬇️
... and 30 more

... and 7 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9584b5e...360eabe. Read the comment docs.

@DaoDaoNoCode
Copy link
Member Author

@jpuzz0 Made required updates and ready for reviewed again.

@Gkrumbach07
Copy link
Member

this looks good. tested without the flag enabled and core flows work still

/lgtm
/approve

Copy link
Contributor

openshift-ci bot commented May 23, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Gkrumbach07

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 23428a2 into opendatahub-io:main May 23, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants