Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RHOAIENG-7439] Pipeline version is not visible for some runs in the run table list #2831

Merged
merged 1 commit into from
May 22, 2024

Conversation

jpuzz0
Copy link
Contributor

@jpuzz0 jpuzz0 commented May 21, 2024

Closes: RHOAIENG-7439

Description

Fetch all pages of pipelines whose IDs are used to fetch all versions, used to display versions in the table cells for runs and for the toolbar version filter dropdown.

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Commits have been squashed into descriptive, self-contained units of work (e.g. 'WIP' and 'Implements feedback' style messages have been removed)
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change (find relevant UX in the SMEs section).

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

@openshift-ci openshift-ci bot requested review from manaswinidas and ppadti May 21, 2024 12:03
Copy link

codecov bot commented May 21, 2024

Codecov Report

Attention: Patch coverage is 76.47059% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 77.41%. Comparing base (cd93b29) to head (5f3b695).
Report is 6 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2831      +/-   ##
==========================================
+ Coverage   77.40%   77.41%   +0.01%     
==========================================
  Files        1101     1101              
  Lines       23168    23192      +24     
  Branches     5841     5848       +7     
==========================================
+ Hits        17933    17954      +21     
- Misses       5235     5238       +3     
Files Coverage Δ
...cepts/pipelines/apiHooks/useAllPipelineVersions.ts 94.73% <100.00%> (ø)
...nd/src/concepts/pipelines/apiHooks/usePipelines.ts 78.78% <75.00%> (-3.57%) ⬇️

... and 6 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd93b29...5f3b695. Read the comment docs.

Copy link
Member

@DaoDaoNoCode DaoDaoNoCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm, just one small suggestion for types, it's OK as it is now though

frontend/src/concepts/pipelines/apiHooks/usePipelines.ts Outdated Show resolved Hide resolved
frontend/src/concepts/pipelines/apiHooks/usePipelines.ts Outdated Show resolved Hide resolved
frontend/src/concepts/pipelines/apiHooks/usePipelines.ts Outdated Show resolved Hide resolved
@openshift-ci openshift-ci bot removed the lgtm label May 21, 2024
Copy link
Member

@DaoDaoNoCode DaoDaoNoCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label May 22, 2024
Copy link
Member

@Gkrumbach07 Gkrumbach07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Copy link
Contributor

openshift-ci bot commented May 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: DaoDaoNoCode, Gkrumbach07

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit cd34c2c into opendatahub-io:main May 22, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants