Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix storage mount location #2820

Closed
wants to merge 1 commit into from

Conversation

strangiato
Copy link
Contributor

Description

Created bug report here:
https://issues.redhat.com/browse/RHOAIRFE-174

This updates the message on the "Edit Workbench" page to fix what path the message indicates where the volume is mounted.

Currently it says:

Cluster storage will mount to /

But the volume is not mounted at root, it is mounted at /opt/app-root/src. See the following snippet from a notebook:

          volumeMounts:
            - mountPath: /opt/app-root/src
              name: test

And the df results from inside the notebook:

$ df -h /opt/app-root/src
Filesystem      Size  Used Avail Use% Mounted on
/dev/sdc         20G   45M   20G   1% /opt/app-root/src

How Has This Been Tested?

Test Impact

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Commits have been squashed into descriptive, self-contained units of work (e.g. 'WIP' and 'Implements feedback' style messages have been removed)
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change (find relevant UX in the SMEs section).

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

@openshift-ci openshift-ci bot requested review from lucferbux and manaswinidas May 16, 2024 20:15
Copy link
Contributor

openshift-ci bot commented May 16, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign gkrumbach07 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the needs-ok-to-test The openshift bot needs to label PRs from non members to avoid strain on the CI label May 16, 2024
Copy link
Contributor

openshift-ci bot commented May 16, 2024

Hi @strangiato. Thanks for your PR.

I'm waiting for a opendatahub-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

codecov bot commented May 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.31%. Comparing base (6d6542b) to head (2128084).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2820      +/-   ##
==========================================
+ Coverage   77.26%   77.31%   +0.04%     
==========================================
  Files        1099     1099              
  Lines       23143    23143              
  Branches     5824     5824              
==========================================
+ Hits        17882    17893      +11     
+ Misses       5261     5250      -11     
Files Coverage Δ
...src/pages/projects/screens/spawner/SpawnerPage.tsx 94.00% <ø> (ø)

... and 5 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d6542b...2128084. Read the comment docs.

@andrewballantyne
Copy link
Member

Needs UX & a wider set of changes. See the ticket for more information (moved to the eng board: https://issues.redhat.com/browse/RHOAIENG-7681)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-ok-to-test The openshift bot needs to label PRs from non members to avoid strain on the CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants