-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge smarter jupyter values #2803
Merge smarter jupyter values #2803
Conversation
b7bbc8e
to
3e391d0
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: christianvogt, gitdallas The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2803 +/- ##
=======================================
Coverage ? 77.25%
=======================================
Files ? 1072
Lines ? 22417
Branches ? 5666
=======================================
Hits ? 17318
Misses ? 5099
Partials ? 0 Continue to review full report in Codecov by Sentry.
|
3e391d0
to
895c60f
Compare
The Changes works for both addition and substraction 💯 |
https://issues.redhat.com/browse/RHOAIENG-7070
Description
Improves the merging of env values provided as part of the Jupyter Tile.
How Has This Been Tested?
It failed after the 2nd start (no4 above) with an error in the modal -- if it continues to deploy, the fix is successful.
Test Impact
Wrote tests for the customizer function used in lodash
mergeWith
Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
main