-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Render pipeline topology correctly, add missing nodes #2796
Render pipeline topology correctly, add missing nodes #2796
Conversation
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code looks good, will test it live now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Gkrumbach07 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
1 similar comment
/retest |
Resolves:
RHOAIENG-6319
RHOAIENG-6572
RHOAIENG-6671
Description
This PR is resolving several issues when rendering the pipeline topology. Now it can find all the edges and nodes correctly. More details will be explained in the comments below.
How Has This Been Tested?
Compare the topology with the KF UI to see if it renders the same, and make sure there are no missing nodes and edges for any pipelines.
Test Impact
Updated some jest test cases.
Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
main