Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add execution details page #2772

Merged

Conversation

DaoDaoNoCode
Copy link
Member

@DaoDaoNoCode DaoDaoNoCode commented May 2, 2024

JIRA: https://issues.redhat.com/browse/RHOAIENG-4778

Description

Add details page for the executions

Screenshot 2024-05-02 at 10 30 46 AM Screenshot 2024-05-02 at 10 30 58 AM

How Has This Been Tested?

  1. Go to the executions table
  2. Click on the execution name
  3. Check the details page, make sure the sections are accurate, you can compare it with the KF UI

Test Impact

N/A

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Commits have been squashed into descriptive, self-contained units of work (e.g. 'WIP' and 'Implements feedback' style messages have been removed)
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change (find relevant UX in the SMEs section).

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

Copy link
Member

@Gkrumbach07 Gkrumbach07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks really good. going to test it live quick

@Gkrumbach07
Copy link
Member

When you are ready can you squash commits and then this is good to merge

@DaoDaoNoCode DaoDaoNoCode force-pushed the jira-rhoaieng-4778 branch from e3f850a to a22e785 Compare May 3, 2024 13:33
@DaoDaoNoCode
Copy link
Member Author

@Gkrumbach07 Yeah I have squashed the commits.

@Gkrumbach07
Copy link
Member

thanks

/lgtm
/approve

Copy link
Contributor

openshift-ci bot commented May 3, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Gkrumbach07

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label May 3, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 521f401 into opendatahub-io:main May 3, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants