[RHOAIENG-5497] Enable the landing page #2767
Conversation
|
/hold Needs a review from PM before we enable it for the product. |
| visit(homeEnabled = false) { | ||
| cy.visit(homeEnabled ? '/enabled' : '/'); | ||
| visit() { | ||
| cy.visit('/enabled'); |
There was a problem hiding this comment.
I don't understand why you changed this... the home page can still be disabled
There was a problem hiding this comment.
I could add it back but it's not set in any of the callers.
There was a problem hiding this comment.
You had a test to make sure the URL redirect was properly tested with and without the feature enabled. I'm feeling you had to have dropped something or we are missing something if it's no longer used.
This cannot be right I would think 🤔 Not sure where the gap is...
There was a problem hiding this comment.
I changed the test to verify that / takes you to the enabled page if the flag is disabled:
https://github.com/opendatahub-io/odh-dashboard/pull/2767/files#diff-34ec9e23c634748dc1ed7b69552b385bf9a11a5a746b7e4779c48e3302f9699aR19
jeff-phillips-18
force-pushed
the
home-page-enable
branch
2 times, most recently
from
c0a45ba to
ff9d516
Compare
jeff-phillips-18
force-pushed
the
home-page-enable
branch
from
ff9d516 to
add90d9
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2767 +/- ##
==========================================
- Coverage 77.40% 77.40% -0.01%
==========================================
Files 1101 1101
Lines 23176 23176
Branches 5843 5843
==========================================
- Hits 17940 17939 -1
- Misses 5236 5237 +1 see 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andrewballantyne The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Closes: RHOAIENG-5497
Description
Changes the default for
disableHometo true in the dashboard config thus enabling the new Landing Page by default.How Has This Been Tested?
Tested locally
Test Impact
Updated tests to verify that the default state shows the landing page.
Request review criteria: