Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RHOAIENG-6321] Home Page Microcopy Updates #2764

Merged

Conversation

jeff-phillips-18
Copy link
Contributor

Closes: RHOAIENG-6321

Description

Content update for the informational section of the landing page

How Has This Been Tested?

Manually tested

Test Impact

Added e2e test to verify the content is adjusted based on feature availability.

Screen shots

Full features (with model mesh enabled)

image

image

image

Full features (with model mesh disabled)

image

Pipelines disabled

image

image

Model serving disabled

image

Pipelines and Model Serving disabled

image

Request review criteria:

  • The developer has manually tested the changes and verified that the changes work
  • Commits have been squashed into descriptive, self-contained units of work (e.g. 'WIP' and 'Implements feedback' style messages have been removed)
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)
  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change (find relevant UX in the SMEs section).

/cc @jgiardino

Copy link
Contributor

openshift-ci bot commented Apr 30, 2024

@jeff-phillips-18: GitHub didn't allow me to request PR reviews from the following users: jgiardino.

Note that only opendatahub-io members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

Closes: RHOAIENG-6321

Description

Content update for the informational section of the landing page

How Has This Been Tested?

Manually tested

Test Impact

Added e2e test to verify the content is adjusted based on feature availability.

Screen shots

Full features (with model mesh enabled)

image

image

image

Full features (with model mesh disabled)

image

Pipelines disabled

image

image

Model serving disabled

image

Pipelines and Model Serving disabled

image

Request review criteria:

  • The developer has manually tested the changes and verified that the changes work
  • Commits have been squashed into descriptive, self-contained units of work (e.g. 'WIP' and 'Implements feedback' style messages have been removed)
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)
  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change (find relevant UX in the SMEs section).

/cc @jgiardino

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Member

@andrewballantyne andrewballantyne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Content is by Katie, not reviewing it closely. Couple questions about code organization.

👍 nice cleanup on tests.

frontend/src/pages/home/aiFlows/CreateAndTrainGallery.tsx Outdated Show resolved Hide resolved
frontend/src/pages/home/aiFlows/ProjectsGallery.tsx Outdated Show resolved Hide resolved
<span>
Projects allow you and your team to organize and collaborate on resources within separate
namespaces.
<br />

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to wrap separate paragraphs with separate <p> or <small> elements to get spacing defined via PF styles instead?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jgiardino It is already in a <small>, would the <br> not be sized as one line height of the small? I can change it to be specified by every caller of the <InfoGalleryItem> rather than in the common component.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rule-of-thumb I've always followed is to use separate <p> tags for separate paragraphs to get the preferred spacing between paragraphs. In this case, the space between would be slightly different if implemented as separate <small> elements vs using <br>. TBH, I'm not sure if there are any a11y implications with using line breaks vs separate <small> elements, so it may just be a cosmetic issue.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I've updated it to use multiple <small> components.

@jeff-phillips-18 jeff-phillips-18 force-pushed the home-page-content branch 2 times, most recently from 9311197 to 8a237c2 Compare April 30, 2024 17:55
@openshift-ci openshift-ci bot added the lgtm label Apr 30, 2024
Copy link
Contributor

openshift-ci bot commented Apr 30, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andrewballantyne

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 95fb721 into opendatahub-io:main Apr 30, 2024
6 checks passed
@jeff-phillips-18 jeff-phillips-18 deleted the home-page-content branch November 12, 2024 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants