-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RHOAIENG-6321] Home Page Microcopy Updates #2764
[RHOAIENG-6321] Home Page Microcopy Updates #2764
Conversation
@jeff-phillips-18: GitHub didn't allow me to request PR reviews from the following users: jgiardino. Note that only opendatahub-io members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Content is by Katie, not reviewing it closely. Couple questions about code organization.
👍 nice cleanup on tests.
9e97d22
to
a83c39c
Compare
<span> | ||
Projects allow you and your team to organize and collaborate on resources within separate | ||
namespaces. | ||
<br /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible to wrap separate paragraphs with separate <p>
or <small>
elements to get spacing defined via PF styles instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jgiardino It is already in a <small>
, would the <br>
not be sized as one line height of the small? I can change it to be specified by every caller of the <InfoGalleryItem>
rather than in the common component.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The rule-of-thumb I've always followed is to use separate <p>
tags for separate paragraphs to get the preferred spacing between paragraphs. In this case, the space between would be slightly different if implemented as separate <small>
elements vs using <br>
. TBH, I'm not sure if there are any a11y implications with using line breaks vs separate <small>
elements, so it may just be a cosmetic issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, I've updated it to use multiple <small>
components.
9311197
to
8a237c2
Compare
8a237c2
to
5d57671
Compare
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andrewballantyne The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Closes: RHOAIENG-6321
Description
Content update for the informational section of the landing page
How Has This Been Tested?
Manually tested
Test Impact
Added e2e test to verify the content is adjusted based on feature availability.
Screen shots
Full features (with model mesh enabled)
Full features (with model mesh disabled)
Pipelines disabled
Model serving disabled
Pipelines and Model Serving disabled
Request review criteria:
/cc @jgiardino