Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RHOAIENG-6606] Correctly nav to application from Jupyter card #2759

Merged

Conversation

jeff-phillips-18
Copy link
Contributor

Fixes: RHOAIENG-6606

Description

Update the link URL for the Jupyter card Launch application link to not be a relative path.

How Has This Been Tested?

Tested with the home page disabled and enabled.

Test Impact

Added an e2e test to check the launch application link with and without the home page feature enabled.

Request review criteria:

  • The developer has manually tested the changes and verified that the changes work
  • Commits have been squashed into descriptive, self-contained units of work (e.g. 'WIP' and 'Implements feedback' style messages have been removed)
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

Copy link
Member

@andrewballantyne andrewballantyne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One tiny change for organization, everything else is good to go. Works well, just I feel for maintenance we can clean this up a tad while we are here.

frontend/src/components/OdhAppCard.tsx Outdated Show resolved Hide resolved
@openshift-ci openshift-ci bot added the lgtm label Apr 30, 2024
Copy link
Contributor

openshift-ci bot commented Apr 30, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andrewballantyne

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 6af67f5 into opendatahub-io:main Apr 30, 2024
6 checks passed
@jeff-phillips-18 jeff-phillips-18 deleted the notebook-page-fix branch April 30, 2024 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants