Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Executions empty state and table #2753

Merged

Conversation

DaoDaoNoCode
Copy link
Member

@DaoDaoNoCode DaoDaoNoCode commented Apr 26, 2024

JIRA:
RHOAIENG-4776
RHOAIENG-4777

Description

Empty state:
Screenshot 2024-04-29 at 4 10 40 PM

Executions table:
Screenshot 2024-04-29 at 4 12 52 PM

How Has This Been Tested?

  1. Go to the executions page under Experiment navigation
  2. Check the list
  3. Check the paging and filtering

Test Impact

N/A

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Commits have been squashed into descriptive, self-contained units of work (e.g. 'WIP' and 'Implements feedback' style messages have been removed)
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change (find relevant UX in the SMEs section).

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress This PR is in WIP state label Apr 26, 2024
@openshift-ci openshift-ci bot requested review from lucferbux and uidoyen April 26, 2024 21:49
@DaoDaoNoCode DaoDaoNoCode requested review from Gkrumbach07 and jpuzz0 and removed request for uidoyen and lucferbux April 26, 2024 22:07
@DaoDaoNoCode DaoDaoNoCode force-pushed the jira-rhoaieng-4776 branch 3 times, most recently from 4ff3a0d to fdc3a56 Compare April 29, 2024 20:27
@DaoDaoNoCode DaoDaoNoCode changed the title [WIP] Executions empty state and table Executions empty state and table Apr 29, 2024
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress This PR is in WIP state label Apr 29, 2024
@Gkrumbach07
Copy link
Member

tested code and everything works

/lgtm
/approve

Copy link
Contributor

openshift-ci bot commented Apr 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Gkrumbach07

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Gkrumbach07
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Apr 29, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 84ac502 into opendatahub-io:main Apr 29, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants