Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add route switching and proxy handling #2747

Merged
merged 1 commit into from
Apr 30, 2024

Conversation

lucferbux
Copy link
Contributor

@lucferbux lucferbux commented Apr 25, 2024

Closes https://issues.redhat.com/browse/RHOAIENG-5141

Description

Update the service proxy to handle multiple model registries in a namespace.

Bring the model registry selector to the top.

Refactor the model registry selector context.

model registry

How Has This Been Tested?

Deploy the PR in the cluster with quay.io/repository/opendatahub/odh-dashboard:pr-2747

  1. Go to the Model Registry section
  2. Switch between Model Registries
  3. Check how it's fetching the right routes

Test Impact

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Commits have been squashed into descriptive, self-contained units of work (e.g. 'WIP' and 'Implements feedback' style messages have been removed)
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change (find relevant UX in the SMEs section).

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

@lucferbux
Copy link
Contributor Author

/hold

@openshift-ci openshift-ci bot requested review from ppadti and uidoyen April 25, 2024 11:09
@openshift-ci openshift-ci bot added the do-not-merge/hold This PR is hold for some reason label Apr 25, 2024
@lucferbux lucferbux force-pushed the rhoaieng-5141 branch 2 times, most recently from 0726f1f to 70298eb Compare April 25, 2024 13:16
@lucferbux lucferbux changed the title Refactor model registry routes and configuration in ModelRegistryCore… Add route switching and proxy handling Apr 25, 2024
@lucferbux
Copy link
Contributor Author

@yih-wang This is the progress and change of layout with the Model Registry switcher.

@lucferbux lucferbux force-pushed the rhoaieng-5141 branch 2 times, most recently from f27dfa4 to 9350de4 Compare April 26, 2024 00:19
@yih-wang
Copy link

@lucferbux That looks good. Thanks for all the efforts here!

@lucferbux lucferbux removed the do-not-merge/hold This PR is hold for some reason label Apr 26, 2024
frontend/src/app/App.tsx Outdated Show resolved Hide resolved
@lucferbux lucferbux force-pushed the rhoaieng-5141 branch 2 times, most recently from 7656475 to 518681e Compare April 30, 2024 09:10
@lucferbux lucferbux requested a review from dpanshug April 30, 2024 09:10
Copy link
Contributor

@dpanshug dpanshug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, just a small change

…Loader.tsx, ModelRegistryRoutes.tsx, and InvalidModelRegistry.tsx
Copy link
Contributor

@mturley mturley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I have one non-blocking question though.

@lucferbux
Copy link
Contributor Author

/approve

Copy link
Contributor

openshift-ci bot commented Apr 30, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lucferbux, mturley

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 3aa9f3b into opendatahub-io:main Apr 30, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants