-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add route switching and proxy handling #2747
Add route switching and proxy handling #2747
Conversation
/hold |
0726f1f
to
70298eb
Compare
@yih-wang This is the progress and change of layout with the Model Registry switcher. |
f27dfa4
to
9350de4
Compare
@lucferbux That looks good. Thanks for all the efforts here! |
frontend/src/pages/modelRegistry/screens/EmptyRegisteredModels.tsx
Outdated
Show resolved
Hide resolved
9350de4
to
aadec00
Compare
frontend/src/pages/modelRegistry/screens/InvalidModelRegistry.tsx
Outdated
Show resolved
Hide resolved
7656475
to
518681e
Compare
518681e
to
a4bf524
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, just a small change
frontend/src/pages/modelRegistry/screens/ModelRegistrySelectorNavigator.tsx
Outdated
Show resolved
Hide resolved
…Loader.tsx, ModelRegistryRoutes.tsx, and InvalidModelRegistry.tsx
a4bf524
to
93a3c0a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I have one non-blocking question though.
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lucferbux, mturley The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Closes https://issues.redhat.com/browse/RHOAIENG-5141
Description
Update the service proxy to handle multiple model registries in a namespace.
Bring the model registry selector to the top.
Refactor the model registry selector context.
How Has This Been Tested?
Deploy the PR in the cluster with
quay.io/repository/opendatahub/odh-dashboard:pr-2747
Test Impact
Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
main