Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed ux on label text #2112

Merged
merged 1 commit into from
Nov 9, 2023

Conversation

Gkrumbach07
Copy link
Member

@Gkrumbach07 Gkrumbach07 commented Nov 9, 2023

closes: #1370

Description

Updated text to lowercase and bolded text in popover

image

How Has This Been Tested?

run storybook and navigate to the unknown story to view what a image looks like when a workbench references an image that does not exists and does not have a past name

Test Impact

updated test to reflect Unknown to unknown

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Commits have been squashed into descriptive, self-contained units of work (e.g. 'WIP' and 'Implements feedback' style messages have been removed)
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit tests & storybook for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change (find relevant UX in the SMEs section).

@xianli123 This is just a fix from the past mocks

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

updated tests
@christianvogt
Copy link
Contributor

/lgtm
/approve

Copy link
Contributor

openshift-ci bot commented Nov 9, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: christianvogt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Nov 9, 2023
@andrewballantyne
Copy link
Member

/override "Delete quay image on PR closed / delete-pr-quay-image (pull_request)"

Copy link
Contributor

openshift-ci bot commented Nov 9, 2023

@andrewballantyne: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

  • Delete quay image on PR closed / delete-pr-quay-image (pull_request)

Only the following failed contexts/checkruns were expected:

  • ci/prow/images
  • ci/prow/odh-dashboard-pr-image-mirror
  • delete-pr-quay-image
  • pull-ci-opendatahub-io-odh-dashboard-incubation-images
  • pull-ci-opendatahub-io-odh-dashboard-main-odh-dashboard-pr-image-mirror
  • tide

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to this:

/override "Delete quay image on PR closed / delete-pr-quay-image (pull_request)"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@andrewballantyne
Copy link
Member

/override delete-pr-quay-image

Copy link
Contributor

openshift-ci bot commented Nov 9, 2023

@andrewballantyne: Overrode contexts on behalf of andrewballantyne: delete-pr-quay-image

In response to this:

/override delete-pr-quay-image

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-bot openshift-merge-bot bot merged commit 41a2ee5 into opendatahub-io:main Nov 9, 2023
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Store the Notebook Image Name
3 participants