Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

omit enable-auth and enable-route annotations for ServingRuntime when disabled #2037

Conversation

christianvogt
Copy link
Contributor

@christianvogt christianvogt commented Oct 31, 2023

Related to: #2050

Description

enable-auth and enable-route are not used by kserve. Therefore it's a bit odd to see enable-route: 'false' and have kserve create a route.

This change simply omits these annotations altogether unless their values are set to 'true'.

How Has This Been Tested?

  • Deploy a kserve model.
  • Inspect the ServingRuntime for the enable-auth and enable-route annotations to not be present.
  • Similarly, create a model server. Disable route creation and auth.
  • Inspect the ServingRuntime for the enable-auth and enable-route annotations to not be present.
  • Create another model server. Enable route creation and auth.
  • Inspect the ServingRuntime for the enable-auth and enable-route annotations to have values 'true'.

Test Impact

New unit tests.

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Commits have been squashed into descriptive, self-contained units of work (e.g. 'WIP' and 'Implements feedback' style messages have been removed)
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit tests & storybook for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change (find relevant UX in the SMEs section).

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

Copy link
Contributor

@lucferbux lucferbux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Contributor

openshift-ci bot commented Nov 2, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lucferbux

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Nov 2, 2023
@openshift-ci openshift-ci bot merged commit 693ffc6 into opendatahub-io:f/model-serving Nov 2, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants