Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Could not find TrustyAI service #2033

Merged
merged 1 commit into from
Nov 1, 2023

Conversation

pnaik1
Copy link
Contributor

@pnaik1 pnaik1 commented Oct 31, 2023

Closes: #1532

Description

When uninstalling TrustyAI from the dashboard settings menu , it gets uninstalled

Screencast.from.2023-10-31.13-42-27.webm

How Has This Been Tested?

  1. Use a dashboard build of f/mserving-metrics branch
  2. Create a new data science project
  3. Go to the settings tab
  4. Click 'Enable TrustyAI'
  5. Wait ~1 minute for the TrustyAI service to spin up (note due to a separate bug the success banner will show immediately, you still need to wait)
  6. Uncheck the "Enable TrustyAI" checkbox
  7. Confirm the deletion and click uninstall

Test Impact

NA

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Commits have been squashed into descriptive, self-contained units of work (e.g. 'WIP' and 'Implements feedback' style messages have been removed)
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit tests & storybook for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change (find relevant UX in the SMEs section).

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

Copy link
Contributor

@manaswinidas manaswinidas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works fine.

/lgtm

@ppadti
Copy link
Contributor

ppadti commented Oct 31, 2023

working fine.
/lgtm

@alexcreasy
Copy link
Contributor

/APPROVE

Tested, working fine.
Thanks Purva :)

Copy link
Contributor

openshift-ci bot commented Nov 1, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexcreasy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Nov 1, 2023
@openshift-ci openshift-ci bot merged commit 435dea0 into opendatahub-io:f/mserving-metrics Nov 1, 2023
3 checks passed
@pnaik1 pnaik1 deleted the issue-1532 branch July 22, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants