-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Accelerator section in Admin Panel and feature flag #2002
Add Accelerator section in Admin Panel and feature flag #2002
Conversation
Skipping CI for Draft Pull Request. |
/test all |
0c62def
to
aeb54fc
Compare
aeb54fc
to
d162244
Compare
@kaedward In the mocks you gave concern on the wording of the empty state, The empty state is for admins to add accelerator profile CRs (gpus). Accelerator profiles are used to sync the use of gpus in the UI to the physical hardware in the cluster. Essentially an admin would go add an accelerator profile after they configured actual accelerators in the openshift console. |
please add tests too @dpanshug |
5f8c511
to
4586d5f
Compare
4586d5f
to
db98e21
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few things and then should be good to go
frontend/src/__tests__/integration/pages/acceleratorProfiles/AcceleratorProfiles.spec.ts
Outdated
Show resolved
Hide resolved
frontend/src/__tests__/integration/pages/acceleratorProfiles/AcceleratorProfiles.stories.tsx
Outdated
Show resolved
Hide resolved
db98e21
to
cf619d7
Compare
cf619d7
to
7f8e230
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
@andrewballantyne this is ready for your review/approval
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: Gkrumbach07 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
d15f8aa
into
opendatahub-io:f/accelerator-admin-support
Thanks for the details, @Gkrumbach07 ! I think my problem was more with the phrasing - usually we wouldn't tell a user to go ask someone about something if we don't know for certain who that person is or if it is the current user. It's different if we're asking them to go ask their admin for some permission, but here we're not sure. This is based on @yannnz's comment in the mocks, which was 4 months ago so is probably outdated: " I believe they need to check the availability of accelerators in cluster, although it’s unclear who they should check with." LMK if this is outdated and the info in the screenshot above is correct, and I can write another suggestion. For now though, I would recommend something more like this: "No accelerator profiles yet This is more straight-forward and allows the user to figure out who they need to talk to (if anyone). I also removed the "please" which we try to avoid, and updated the button to "Create" instead of "Add" since we refer to this as "Create" everywhere else. Please LMK what you think! |
Closes: #1372
Description
Added new feature flag
disableAccelerators
and new section in the admin panel for accelerators.How Has This Been Tested?
odh-dasboard/manifests/crd/acceleratorprofiles.opendatahub.io.crd.yaml
Note: This PR only provides empty state of the page, so make sure you don't have any AcceleratorProfile operand in your cluster.
Test Impact
Integration testing: To test Empty State of no Accelerator profile and created storybook too.
Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
main
cc @yannnz