Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add check for dsc status and utility types to check serving platform availablity #1990

Merged
merged 1 commit into from
Oct 23, 2023

Conversation

lucferbux
Copy link
Contributor

@lucferbux lucferbux commented Oct 19, 2023

Closes #1946

Description

Add check for dsc status and utility types to check serving platform availability

How Has This Been Tested?

  1. You can check the status of the cluster adding this effect into any component in the dashboard
  React.useEffect(() => {
    fetchClusterStatus().then((status) => {
      const { kServeAvailable, modelMeshAvailable } = checkPlatformAvailability(status);
      console.log(kServeAvailable);
      console.log(modelMeshAvailable);
      console.log(checkKserveFailureStatus(status));
    });
  }, []);

Test Impact

Unit testing the cluster status

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Commits have been squashed into descriptive, self-contained units of work (e.g. 'WIP' and 'Implements feedback' style messages have been removed)
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit tests & storybook for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change (find relevant UX in the SMEs section).

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress This PR is in WIP state label Oct 19, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 19, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@lucferbux lucferbux changed the title [WIP] Add check for dsc status and utility types to check serving platform availablity Add check for dsc status and utility types to check serving platform availablity Oct 20, 2023
@lucferbux lucferbux removed the do-not-merge/work-in-progress This PR is in WIP state label Oct 20, 2023
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress This PR is in WIP state label Oct 20, 2023
@lucferbux lucferbux marked this pull request as ready for review October 20, 2023 12:05
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress This PR is in WIP state label Oct 20, 2023
@openshift-ci openshift-ci bot requested review from alexcreasy and pnaik1 October 20, 2023 12:05
@lucferbux
Copy link
Contributor Author

@uidoyen @accorvin @DaoDaoNoCode This is the last piece of the foundational work, this should help us to detect wether the platform are available in the cluster and if there's an issue with either kserve or modelmesh (for the error pages)

@lucferbux lucferbux linked an issue Oct 20, 2023 that may be closed by this pull request
Copy link
Member

@DaoDaoNoCode DaoDaoNoCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Oct 23, 2023
@christianvogt
Copy link
Contributor

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 23, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: christianvogt, DaoDaoNoCode

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot merged commit bfb3aa8 into opendatahub-io:f/model-serving Oct 23, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Story]: Add logic to detect if kserve or modelmesh are installed
4 participants