Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error creating pipeline server when data connection endpoint omits scheme #1778

Merged
merged 1 commit into from
Sep 15, 2023

Conversation

christianvogt
Copy link
Contributor

Closes: #1350

Depends on #1773 for unit tests.

Description

When creating a data connect whose endpoint does not include a scheme in the URL, creating of a pipeline server will fail with a javascript error attempting to access a property of an undefined value. This is because the regex used to parse the data connection endpoint URL assumed a scheme would always be present.

This change does not affect the UI / UX.

How Has This Been Tested?

  1. Create a data connection
  2. set the endpoint to s3.amazonaws.com
  3. Create a pipeline server
  4. Select pre-existing data connection
  5. Click Configure button

Test Impact

Added unit test.

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Commits have been squashed into descriptive, self-contained units of work (e.g. 'WIP' and 'Implements feedback' style messages have been removed)
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit tests & storybook for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change (find relevant UX in the SMEs section).

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

@DaoDaoNoCode
Copy link
Member

Can you rebase this PR? There is a commit from another PR.

@christianvogt
Copy link
Contributor Author

@DaoDaoNoCode rebased. The other commit was a dependency on the relocation of unit tests that got merged.

Copy link
Contributor

@lucferbux lucferbux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Tested a connection without scheme with and without these changes and works as expected.

Copy link
Member

@DaoDaoNoCode DaoDaoNoCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@lucferbux
Copy link
Contributor

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 15, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: DaoDaoNoCode, lucferbux

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Pipelines server creation fails on incorrectly formatted s3 endpoint
4 participants