Add shm to ServingRuntime volumes and volumeMounts

[DaoDaoNoCode]

Closes #1685

Description

Apply shm volumes and volumeMounts when creating or updating (this is for backward compatibility, let me know if we want only to apply this to the future created serving runtimes @lucferbux ) the serving runtime.

How Has This Been Tested?

1. Create a model server
2. Check the YAML object of the model server (ServingRuntime), make sure you can see the following in the container

volumeMounts:
  - mountPath: /dev/shm
  name: shm

and the following in the spec:

volumes:
  - emptyDir:
    medium: Memory
    sizeLimit: 2Gi
  name: shm

Test Impact

N/A

Request review criteria:

Self checklist (all need to be checked):

• The developer has manually tested the changes and verified that the changes work
• Commits have been squashed into descriptive, self-contained units of work (e.g. 'WIP' and 'Implements feedback' style messages have been removed)
• Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
• The developer has added tests or explained why testing cannot be added (unit tests & storybook for related changes)

If you have UI changes:

• Included any necessary screenshots or gifs if it was a UI change.
• Included tags to the UX team if it was a UI/UX change (find relevant UX in the SMEs section).

After the PR is posted & before it merges:

• The developer has tested their solution on a cluster by using the image produced by the PR to main

[Gkrumbach07]

adds the expected volume info

/lgtm

[lucferbux]

@DaoDaoNoCode Can you add test coverage for this, I think just adding unit test coverage for the utils functions should be enough for this. Thanks in advance!

[manaswinidas]

/lgtm

I can see the changes in the console.

[Gkrumbach07]

Can you add test coverage for this, I think just adding unit test coverage for the utils functions should be enough for this. Thanks in advance!

I think andrew added the no tests allowed of this PR @lucferbux

[lucferbux]

Can you add test coverage for this, I think just adding unit test coverage for the utils functions should be enough for this. Thanks in advance!

I think andrew added the no tests allowed of this PR @lucferbux

Oh you are right! Let me do a review then!

[lucferbux]

Tested and overal looks great, but I wouldn't assume there's only one container, I haven't seen any Custom Serving Runtime with more than one container but if the spec supports multiple, let's just not assume that.

[DaoDaoNoCode]

@lucferbux Can you review it again? I updated the PR based on the feedback.

[DaoDaoNoCode]

/retest

[lucferbux]

/lgtm

ok, the logic seems great, I've tested both new Serving Runtime and updating and old one, as well as adding a volume to a preexisting Custom Serving Runtime with two containers, one with a volume called shmdev and it works as expected (btw, these are good testing ideas for the future)

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lucferbux

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [lucferbux]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment