Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Bias metric chart selector shows a selected, non-existent chart when metrics are deleted by direct call to the TrustyAI API #1533

Closed
alexcreasy opened this issue Jul 18, 2023 · 0 comments · Fixed by #2009
Assignees
Labels
feature/explainability priority/normal An issue with the product; fix when possible

Comments

@alexcreasy
Copy link
Contributor

Reproducer:

  • Create a bias metric configs
  • navigate to the model bias tab
  • Select that chart using the selector
  • Delete that bias metric by making a call against the TrustyAI API directly
  • Refresh the page

Observed outcome:

  • See the image, you can see that the "Loan acceptance" chart is selected, even though it no longer exists, the selector is disabled and the "Bias metrics not configured" empty state is visible.

Expected outcome:

  • No metrics should be selected

Additional information:
This is due to a stale entry in the browser storage. When the metric config is deleted via the dashboard, the entry is removed from the browser storage at the same time, so this bug is not observed when only using the dashboard. The component will need to check if any selected metrics exist on the trustyai side when it mounts and clear them from the browser storage if they do not.

odh-dashboard-opendatahub apps acreasy 4t8o p1 openshiftapps com_projects_alex-test-dsp (1)

@alexcreasy alexcreasy added this to the Explainability Phase 1 milestone Jul 18, 2023
@github-project-automation github-project-automation bot moved this to Needs prioritization in ODH Dashboard Planning Jul 18, 2023
@alexcreasy alexcreasy changed the title [BUG] Bias metric chart selector shows a selected, non-existent chart when requests are deleted by direct call to the TrustyAI API [BUG] Bias metric chart selector shows a selected, non-existent chart when metrics are deleted by direct call to the TrustyAI API Jul 18, 2023
@manaswinidas manaswinidas moved this from Needs prioritization to To do in ODH Dashboard Planning Jul 18, 2023
@manaswinidas manaswinidas added the priority/normal An issue with the product; fix when possible label Jul 18, 2023
@alexcreasy alexcreasy moved this from Dev To do to Dev In progress in ODH Dashboard Planning Oct 24, 2023
@alexcreasy alexcreasy moved this to In Progress in Internal tracking Oct 24, 2023
@alexcreasy alexcreasy moved this to Dashboard in ODH Feature Tracking Oct 24, 2023
alexcreasy added a commit to alexcreasy/odh-dashboard that referenced this issue Oct 24, 2023
…t when metrics are deleted by direct call to the TrustyAI API (opendatahub-io#1533)
@alexcreasy alexcreasy self-assigned this Oct 24, 2023
alexcreasy added a commit to alexcreasy/odh-dashboard that referenced this issue Oct 30, 2023
…t when metrics are deleted by direct call to the TrustyAI API (opendatahub-io#1533)
alexcreasy added a commit to alexcreasy/odh-dashboard that referenced this issue Oct 30, 2023
…t when metrics are deleted by direct call to the TrustyAI API (opendatahub-io#1533)
alexcreasy added a commit to alexcreasy/odh-dashboard that referenced this issue Oct 30, 2023
…t when metrics are deleted by direct call to the TrustyAI API (opendatahub-io#1533)
@github-project-automation github-project-automation bot moved this from In Progress to Done in Internal tracking Nov 1, 2023
@github-project-automation github-project-automation bot moved this from Dev In progress to Done in ODH Dashboard Planning Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/explainability priority/normal An issue with the product; fix when possible
Projects
Status: Done
Status: No status
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants