Enable pipeline experiments in dashboard config

opendatahub-io · Jun 11, 2024 · f4501d4 · f4501d4
1 parent 10d0ccd
commit f4501d4
Show file tree

Hide file tree

Showing 33 changed files with 422 additions and 217 deletions.
diff --git a/backend/src/utils/constants.ts b/backend/src/utils/constants.ts
@@ -61,7 +61,7 @@ export const blankDashboardCR: DashboardConfig = {
       disableKServeMetrics: true,
       disableModelMesh: false,
       disableAcceleratorProfiles: false,
-      disablePipelineExperiments: true,
+      disablePipelineExperiments: false,
       disableS3Endpoint: true,
       disableDistributedWorkloads: false,
       disableModelRegistry: true,

diff --git a/docs/dashboard-config.md b/docs/dashboard-config.md
@@ -157,7 +157,7 @@ spec:
     disableKServeMetrics: true
     disableBiasMetrics: false
     disablePerformanceMetrics: false
-    disablePipelineExperiments: true
+    disablePipelineExperiments: false
     disableS3Endpoint: true
   notebookController:
     enabled: true

diff --git a/frontend/src/__mocks__/mockDashboardConfig.ts b/frontend/src/__mocks__/mockDashboardConfig.ts
@@ -49,7 +49,7 @@ export const mockDashboardConfig = ({
   disableAcceleratorProfiles = false,
   disablePerformanceMetrics = false,
   disableBiasMetrics = false,
-  disablePipelineExperiments = true,
+  disablePipelineExperiments = false,
   disableS3Endpoint = true,
   disableDistributedWorkloads = false,
   disableModelRegistry = true,

diff --git a/frontend/src/__tests__/cypress/cypress/pages/pipelines/pipelineRunsGlobal.ts b/frontend/src/__tests__/cypress/cypress/pages/pipelines/pipelineRunsGlobal.ts
@@ -2,9 +2,14 @@ import { PipelineRunSearchParam } from '~/concepts/pipelines/content/types';
 import { DeleteModal } from '~/__tests__/cypress/cypress/pages/components/DeleteModal';
 
 class PipelineRunsGlobal {
-  visit(projectName: string, runType?: 'active' | 'archived' | 'scheduled') {
+  visit(
+    projectName: string,
+    pipelineId: string,
+    versionId: string,
+    runType?: 'active' | 'archived' | 'scheduled',
+  ) {
     cy.visitWithLogin(
-      `/pipelineRuns/${projectName}${
+      `/pipelines/${projectName}/pipeline/runs/${pipelineId}/${versionId}${
         runType ? `?${PipelineRunSearchParam.RunType}=${runType}` : ''
       }`,
     );

diff --git a/frontend/src/__tests__/cypress/cypress/pages/pipelines/topology.ts b/frontend/src/__tests__/cypress/cypress/pages/pipelines/topology.ts
@@ -171,7 +171,7 @@ class PipelineDetails extends PipelinesTopology {
 
 class PipelineRunJobDetails extends RunDetails {
   visit(namespace: string, pipelineId: string) {
-    cy.visitWithLogin(`/pipelineRuns/${namespace}/pipelineRunJob/view/${pipelineId}`);
+    cy.visitWithLogin(`/pipeline/${namespace}/pipelineRunJob/view/${pipelineId}`);
     this.wait();
   }
 
@@ -186,7 +186,7 @@ class PipelineRunJobDetails extends RunDetails {
 
 class PipelineRunDetails extends RunDetails {
   visit(namespace: string, pipelineId: string) {
-    cy.visitWithLogin(`/pipelineRuns/${namespace}/pipelineRun/view/${pipelineId}`);
+    cy.visitWithLogin(`/pipeline/${namespace}/pipelineRun/view/${pipelineId}`);
     this.wait();
   }
 

diff --git a/frontend/src/__tests__/cypress/cypress/tests/mocked/pipelines/pipelineCreateRuns.cy.ts b/frontend/src/__tests__/cypress/cypress/tests/mocked/pipelines/pipelineCreateRuns.cy.ts
@@ -57,7 +57,7 @@ const initialMockRecurringRuns = [
 describe('Pipeline create runs', () => {
   beforeEach(() => {
     initIntercepts();
-    pipelineRunsGlobal.visit(projectName);
+    pipelineRunsGlobal.visit(projectName, 'pipeline_id', 'version_id');
   });
 
   it('renders the page with scheduled and active runs table data', () => {
@@ -81,7 +81,7 @@ describe('Pipeline create runs', () => {
 
       // Navigate to the 'Create run' page
       pipelineRunsGlobal.findCreateRunButton().click();
-      verifyRelativeURL(`/pipelineRuns/${projectName}/pipelineRun/create`);
+      verifyRelativeURL(`/pipelines/${projectName}/pipelineRun/create`);
       createRunPage.find();
       createRunPage.findRunTypeSwitchLink().click();
       cy.url().should('include', '?runType=scheduled');
@@ -112,7 +112,7 @@ describe('Pipeline create runs', () => {
 
       // Navigate to the 'Create run' page
       pipelineRunsGlobal.findCreateRunButton().click();
-      verifyRelativeURL(`/pipelineRuns/${projectName}/pipelineRun/create`);
+      verifyRelativeURL(`/pipelines/${projectName}/pipelineRun/create`);
       createRunPage.find();
 
       // Fill out the form without a schedule and submit
@@ -151,7 +151,7 @@ describe('Pipeline create runs', () => {
       });
 
       // Should be redirected to the run details page
-      verifyRelativeURL(`/pipelineRuns/${projectName}/pipelineRun/view/${createRunParams.run_id}`);
+      verifyRelativeURL(`/pipelines/${projectName}/pipelineRun/view/${createRunParams.run_id}`);
     });
 
     it('duplicates an active run', () => {
@@ -182,7 +182,7 @@ describe('Pipeline create runs', () => {
       // Navigate to clone run page for a given active run
       pipelineRunsGlobal.findActiveRunsTab().click();
       activeRunsTable.getRowByName(mockRun.display_name).findKebabAction('Duplicate').click();
-      verifyRelativeURL(`/pipelineRuns/${projectName}/pipelineRun/clone/${mockRun.run_id}`);
+      verifyRelativeURL(`/pipelines/${projectName}/pipelineRun/clone/${mockRun.run_id}`);
 
       // Verify pre-populated values & submit
       cloneRunPage.findExperimentSelect().should('have.text', mockExperiment.display_name);
@@ -217,7 +217,7 @@ describe('Pipeline create runs', () => {
       });
 
       // Should redirect to the details of the newly cloned active run
-      verifyRelativeURL(`/pipelineRuns/${projectName}/pipelineRun/view/${mockDuplicateRun.run_id}`);
+      verifyRelativeURL(`/pipelines/${projectName}/pipelineRun/view/${mockDuplicateRun.run_id}`);
     });
 
     it('create run with default and optional parameters', () => {
@@ -487,7 +487,7 @@ describe('Pipeline create runs', () => {
 
       // Navigate to the 'Create run' page
       pipelineRunsGlobal.findScheduleRunButton().click();
-      verifyRelativeURL(`/pipelineRuns/${projectName}/pipelineRun/create?runType=scheduled`);
+      verifyRelativeURL(`/pipelines/${projectName}/pipelineRun/create?runType=scheduled`);
       createSchedulePage.find();
       createSchedulePage.findRunTypeSwitchLink().click();
       cy.url().should('include', '?runType=active');
@@ -518,7 +518,7 @@ describe('Pipeline create runs', () => {
 
       // Navigate to the 'Create run' page
       pipelineRunsGlobal.findScheduleRunButton().click();
-      verifyRelativeURL(`/pipelineRuns/${projectName}/pipelineRun/create?runType=scheduled`);
+      verifyRelativeURL(`/pipelines/${projectName}/pipelineRun/create?runType=scheduled`);
       createSchedulePage.find();
 
       // Fill out the form with a schedule and submit
@@ -562,7 +562,7 @@ describe('Pipeline create runs', () => {
 
       // Should be redirected to the schedule details page
       verifyRelativeURL(
-        `/pipelineRuns/${projectName}/pipelineRunJob/view/${createRecurringRunParams.recurring_run_id}`,
+        `/pipelines/${projectName}/pipelineRunJob/view/${createRecurringRunParams.recurring_run_id}`,
       );
     });
 
@@ -594,7 +594,7 @@ describe('Pipeline create runs', () => {
         .findKebabAction('Duplicate')
         .click();
       verifyRelativeURL(
-        `/pipelineRuns/${projectName}/pipelineRun/cloneJob/${mockRecurringRun.recurring_run_id}?runType=scheduled`,
+        `/pipelines/${projectName}/pipelineRun/clone/${mockRecurringRun.recurring_run_id}?runType=scheduled`,
       );
 
       // Verify pre-populated values & submit
@@ -640,7 +640,7 @@ describe('Pipeline create runs', () => {
 
       // Should be redirected to the schedule details page
       verifyRelativeURL(
-        `/pipelineRuns/${projectName}/pipelineRunJob/view/${mockDuplicateRecurringRun.recurring_run_id}`,
+        `/pipelines/${projectName}/pipelineRunJob/view/${mockDuplicateRecurringRun.recurring_run_id}`,
       );
     });
 

diff --git a/frontend/src/__tests__/cypress/cypress/tests/mocked/pipelines/pipelineDeleteRuns.cy.ts b/frontend/src/__tests__/cypress/cypress/tests/mocked/pipelines/pipelineDeleteRuns.cy.ts
@@ -78,7 +78,7 @@ describe('Pipeline runs', () => {
     it('Test delete a single schedule', () => {
       initIntercepts();
 
-      pipelineRunsGlobal.visit('test-project');
+      pipelineRunsGlobal.visit('test-project', 'pipeline_id', 'version_id');
       pipelineRunsGlobal.isApiAvailable();
 
       pipelineRunsGlobal.findSchedulesTab().click();
@@ -122,7 +122,7 @@ describe('Pipeline runs', () => {
     it('Test delete multiple schedules', () => {
       initIntercepts();
 
-      pipelineRunsGlobal.visit('test-project');
+      pipelineRunsGlobal.visit('test-project', 'pipeline_id', 'version_id');
       pipelineRunsGlobal.isApiAvailable();
 
       pipelineRunsGlobal.findSchedulesTab().click();
@@ -177,7 +177,7 @@ describe('Pipeline runs', () => {
     it('Test delete a single archived run', () => {
       initIntercepts();
 
-      pipelineRunsGlobal.visit('test-project');
+      pipelineRunsGlobal.visit('test-project', 'pipeline_id', 'version_id');
       pipelineRunsGlobal.isApiAvailable();
 
       pipelineRunsGlobal.findArchivedRunsTab().click();
@@ -222,7 +222,7 @@ describe('Pipeline runs', () => {
     it('Test delete multiple archived runs', () => {
       initIntercepts();
 
-      pipelineRunsGlobal.visit('test-project');
+      pipelineRunsGlobal.visit('test-project', 'pipeline_id', 'version_id');
       pipelineRunsGlobal.isApiAvailable();
 
       pipelineRunsGlobal.findArchivedRunsTab().click();