Remove boldTitle prop and resolve code editor cutoff

opendatahub-io · Dec 19, 2024 · e98d837 · e98d837
1 parent f1af616
commit e98d837
Show file tree

Hide file tree

Showing 7 changed files with 2 additions and 10 deletions.
diff --git a/frontend/src/components/table/TableRowTitleDescription.tsx b/frontend/src/components/table/TableRowTitleDescription.tsx
@@ -6,7 +6,6 @@ import TruncatedText from '~/components/TruncatedText';
 
 type TableRowTitleDescriptionProps = {
   title: React.ReactNode;
-  boldTitle?: boolean;
   titleIcon?: React.ReactNode;
   resource?: K8sResourceCommon;
   subtitle?: React.ReactNode;
@@ -19,7 +18,6 @@ type TableRowTitleDescriptionProps = {
 
 const TableRowTitleDescription: React.FC<TableRowTitleDescriptionProps> = ({
   title,
-  boldTitle = false,
   titleIcon,
   description,
   resource,
@@ -50,7 +48,7 @@ const TableRowTitleDescription: React.FC<TableRowTitleDescriptionProps> = ({
 
   return (
     <div>
-      <div data-testid="table-row-title" className={boldTitle ? 'pf-v6-u-font-weight-bold' : ''}>
+      <div data-testid="table-row-title">
         {resource ? (
           <ResourceNameTooltip resource={resource} wrap={wrapResourceTitle}>
             {title}

diff --git a/...nd/src/concepts/pipelines/content/pipelinesDetails/pipelineRun/PipelineRunDetailsTabs.tsx b/...nd/src/concepts/pipelines/content/pipelinesDetails/pipelineRun/PipelineRunDetailsTabs.tsx
@@ -49,7 +49,7 @@ export const PipelineRunDetailsTabs: React.FC<PipelineRunDetailsTabsProps> = ({
       hasBodyWrapper={false}
       isFilled
       padding={{ default: 'noPadding' }}
-      style={{ flexBasis: 0, overflowY: 'hidden' }}
+      style={{ flexBasis: 0 }}
     >
       <Flex
         direction={{ default: 'column' }}

diff --git a/frontend/src/concepts/pipelines/content/tables/experiment/ExperimentTableRow.tsx b/frontend/src/concepts/pipelines/content/tables/experiment/ExperimentTableRow.tsx
@@ -30,7 +30,6 @@ const ExperimentTableRow: React.FC<ExperimentTableRowProps> = ({
       <CheckboxTd id={experiment.experiment_id} isChecked={isChecked} onToggle={onToggleCheck} />
       <Td dataLabel="Experiment">
         <TableRowTitleDescription
-          boldTitle={false}
           title={
             <Link
               to={

diff --git a/frontend/src/pages/connectionTypes/ConnectionTypesTableRow.tsx b/frontend/src/pages/connectionTypes/ConnectionTypesTableRow.tsx
@@ -87,7 +87,6 @@ const ConnectionTypesTableRow: React.FC<ConnectionTypesTableRowProps> = ({
     <Tr>
       <Td dataLabel={connectionTypeColumns[0].label}>
         <TableRowTitleDescription
-          boldTitle={false}
           title={<Truncate content={getDisplayNameFromK8sResource(obj)} />}
           description={getDescriptionFromK8sResource(obj)}
           truncateDescriptionLines={2}

diff --git a/frontend/src/pages/connectionTypes/manage/ManageConnectionTypeFieldsTableRow.tsx b/frontend/src/pages/connectionTypes/manage/ManageConnectionTypeFieldsTableRow.tsx
@@ -64,7 +64,6 @@ const ManageConnectionTypeFieldsTableRow: React.FC<Props> = ({
         />
         <Td dataLabel={columns[0].label} data-testid="field-name">
           <TableRowTitleDescription
-            boldTitle={false}
             title={
               <Flex gap={{ default: 'gapSm' }} flexWrap={{ default: 'nowrap' }}>
                 <FlexItem>
@@ -132,7 +131,6 @@ const ManageConnectionTypeFieldsTableRow: React.FC<Props> = ({
       />
       <Td dataLabel={columns[0].label} data-testid="field-name" visibility={columns[0].visibility}>
         <TableRowTitleDescription
-          boldTitle={false}
           title={<Truncate content={row.name} />}
           description={row.description}
           truncateDescriptionLines={2}

diff --git a/frontend/src/pages/projects/screens/detail/connections/ConnectionsTableRow.tsx b/frontend/src/pages/projects/screens/detail/connections/ConnectionsTableRow.tsx
@@ -41,7 +41,6 @@ const ConnectionsTableRow: React.FC<ConnectionsTableRowProps> = ({
       <Td dataLabel="Name">
         <TableRowTitleDescription
           title={<Truncate content={getDisplayNameFromK8sResource(obj)} />}
-          boldTitle={false}
           titleIcon={
             showWarningIcon ? (
               <Icon status="warning" className="pf-v6-u-pl-lg">

diff --git a/frontend/src/pages/projects/screens/projects/ProjectTableRow.tsx b/frontend/src/pages/projects/screens/projects/ProjectTableRow.tsx
@@ -71,7 +71,6 @@ const ProjectTableRow: React.FC<ProjectTableRowProps> = ({
       <Tr isControlRow>
         <Td dataLabel="Name">
           <TableRowTitleDescription
-            boldTitle={false}
             title={
               <ResourceNameTooltip resource={project}>
                 <ProjectLink project={project} />