Change imagageurl to be equal with imageselection

opendatahub-io · May 9, 2024 · dd59b96 · dd59b96
1 parent 62b5097
commit dd59b96
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 7 deletions.
diff --git a/backend/src/utils/notebookUtils.ts b/backend/src/utils/notebookUtils.ts
@@ -163,15 +163,13 @@ export const assembleNotebook = async (
 
   const notebookSize = getNotebookSize(notebookSizeName);
 
-  let imageUrl = ``;
   let imageSelection = ``;
 
   try {
     const image = await getImageInfo(fastify, imageName);
 
     const selectedImage = getImageTag(image, imageTagName);
 
-    imageUrl = `${selectedImage.image?.dockerImageRepo}:${selectedImage.tag?.name}`;
     imageSelection = `${selectedImage.image?.name}:${selectedImage.tag?.name}`;
   } catch (e) {
     fastify.log.error(`Error getting the image for ${imageName}:${imageTagName}`);
@@ -285,7 +283,7 @@ export const assembleNotebook = async (
           enableServiceLinks: false,
           containers: [
             {
-              image: imageUrl,
+              image: imageSelection,
               imagePullPolicy: 'Always',
               workingDir: MOUNT_PATH,
               name: name,
@@ -301,7 +299,7 @@ export const assembleNotebook = async (
                 },
                 {
                   name: 'JUPYTER_IMAGE',
-                  value: imageUrl,
+                  value: imageSelection,
                 },
                 ...configMapEnvs,
                 ...secretEnvs,

diff --git a/frontend/src/api/k8s/notebooks.ts b/frontend/src/api/k8s/notebooks.ts
@@ -50,7 +50,6 @@ export const assembleNotebook = (
     existingResources,
   } = data;
   const notebookId = overrideNotebookId || translateDisplayNameForK8s(notebookName);
-  const imageUrl = `${image.imageStream?.status?.dockerImageRepository}:${image.imageVersion?.name}`;
   const imageSelection = `${image.imageStream?.metadata.name}:${image.imageVersion?.name}`;
 
   const { affinity, tolerations, resources } = assemblePodSpecOptions(
@@ -120,7 +119,7 @@ export const assembleNotebook = (
           enableServiceLinks: false,
           containers: [
             {
-              image: imageUrl,
+              image: imageSelection,
               imagePullPolicy: 'Always',
               workingDir: ROOT_MOUNT_PATH,
               name: notebookId,
@@ -136,7 +135,7 @@ export const assembleNotebook = (
                 },
                 {
                   name: 'JUPYTER_IMAGE',
-                  value: imageUrl,
+                  value: imageSelection,
                 },
               ],
               envFrom,