Removed Started at date

opendatahub-io · Oct 26, 2023 · d73145a · d73145a
1 parent c0dca01
commit d73145a
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 4 deletions.
diff --git a/...end/src/concepts/pipelines/content/pipelinesDetails/pipelineRun/PipelineRunTabDetails.tsx b/...end/src/concepts/pipelines/content/pipelinesDetails/pipelineRun/PipelineRunTabDetails.tsx
@@ -12,6 +12,7 @@ import { relativeDuration } from '~/utilities/time';
 import {
   asTimestamp,
   DetailItem,
+  isEmptyDateKF,
   renderDetailItems,
 } from '~/concepts/pipelines/content/pipelinesDetails/pipelineRun/utils';
 type PipelineRunTabDetailsProps = {
@@ -24,7 +25,6 @@ const PipelineRunTabDetails: React.FC<PipelineRunTabDetailsProps> = ({
   workflowName,
 }) => {
   const { namespace, project } = usePipelinesAPI();
-
   if (!pipelineRunKF || !workflowName) {
     return (
       <EmptyState variant={EmptyStateVariant.large} data-id="loading-empty-state">
@@ -62,10 +62,11 @@ const PipelineRunTabDetails: React.FC<PipelineRunTabDetailsProps> = ({
     { key: 'Workflow name', value: workflowName },
     { key: 'Created at', value: asTimestamp(new Date(pipelineRunKF.created_at)) },
     {
-      key: 'Started at',
-      value: asTimestamp(new Date(pipelineRunKF.scheduled_at || pipelineRunKF.created_at)),
+      key: 'Finished at',
+      value: isEmptyDateKF(pipelineRunKF.finished_at)
+        ? 'N/A'
+        : asTimestamp(new Date(pipelineRunKF.finished_at)),
     },
-    { key: 'Finished at', value: asTimestamp(new Date(pipelineRunKF.finished_at)) },
     { key: 'Duration', value: relativeDuration(getRunDuration(pipelineRunKF)) },
   ];
 

diff --git a/frontend/src/concepts/pipelines/content/pipelinesDetails/pipelineRun/utils.tsx b/frontend/src/concepts/pipelines/content/pipelinesDetails/pipelineRun/utils.tsx
@@ -9,6 +9,7 @@ import {
   TimestampFormat,
 } from '@patternfly/react-core';
 import { GlobeAmericasIcon } from '@patternfly/react-icons';
+import { DateTimeKF } from '~/concepts/pipelines/kfTypes';
 
 export type DetailItem = {
   key: string;
@@ -43,3 +44,8 @@ export const asTimestamp = (date: Date): React.ReactNode => (
     </FlexItem>
   </Flex>
 );
+
+export const isEmptyDateKF = (date: DateTimeKF): boolean => {
+  const INVALID_TIMESTAMP = '1970-01-01T00:00:00Z';
+  return date === INVALID_TIMESTAMP ? true : false;
+};