'

opendatahub-io · Aug 15, 2024 · c283776 · c283776
1 parent 05749f7
commit c283776
Show file tree

Hide file tree

Showing 7 changed files with 13 additions and 10 deletions.
diff --git a/frontend/src/__mocks__/mockRegisteredModel.ts b/frontend/src/__mocks__/mockRegisteredModel.ts
@@ -4,7 +4,6 @@ import { createModelRegistryLabelsObject } from './utils';
 type MockRegisteredModelType = {
   id?: string;
   name?: string;
-  author?: string;
   owner?: string;
   state?: ModelState;
   description?: string;
@@ -13,7 +12,6 @@ type MockRegisteredModelType = {
 
 export const mockRegisteredModel = ({
   name = 'test',
-  author = 'Author 1',
   owner = 'Author 1',
   state = ModelState.LIVE,
   description = '',
@@ -27,7 +25,6 @@ export const mockRegisteredModel = ({
   lastUpdateTimeSinceEpoch: '1710404288975',
   name,
   state,
-  author,
   owner,
   customProperties: createModelRegistryLabelsObject(labels),
 });
diff --git a/frontend/src/__tests__/cypress/cypress/tests/mocked/modelRegistry/modelRegistry.cy.ts b/frontend/src/__tests__/cypress/cypress/tests/mocked/modelRegistry/modelRegistry.cy.ts
@@ -66,7 +66,10 @@ const initIntercepts = ({
       ],
     }),
   ],
-  modelVersions = [mockModelVersion({ name: 'model version' })],
+  modelVersions = [
+    mockModelVersion({ author: 'Author 1' }),
+    mockModelVersion({ name: 'model version' }),
+  ],
   allowed = true,
 }: HandlersProps) => {
   cy.interceptOdh(

diff --git a/...end/src/__tests__/cypress/cypress/tests/mocked/modelRegistry/registeredModelArchive.cy.ts b/...end/src/__tests__/cypress/cypress/tests/mocked/modelRegistry/registeredModelArchive.cy.ts
@@ -171,6 +171,7 @@ describe('Restoring archive model', () => {
         description: '',
         externalID: '1234132asdfasdf',
         state: 'LIVE',
+        owner: 'Author 1',
       });
     });
   });
@@ -200,6 +201,7 @@ describe('Restoring archive model', () => {
         description: '',
         externalID: '1234132asdfasdf',
         state: 'LIVE',
+        owner: 'Author 1',
       });
     });
   });
@@ -233,6 +235,7 @@ describe('Archiving model', () => {
         description: '',
         externalID: '1234132asdfasdf',
         state: 'ARCHIVED',
+        owner: 'Author 1',
       });
     });
   });
@@ -266,6 +269,7 @@ describe('Archiving model', () => {
         description: '',
         externalID: '1234132asdfasdf',
         state: 'ARCHIVED',
+        owner: 'Author 1',
       });
     });
   });

diff --git a/frontend/src/concepts/modelRegistry/types.ts b/frontend/src/concepts/modelRegistry/types.ts
@@ -85,8 +85,6 @@ export type ModelRegistryBase = {
   id: string;
   name: string;
   externalID?: string;
-  author?: string;
-  owner?: string;
   description?: string;
   createTimeSinceEpoch?: string;
   lastUpdateTimeSinceEpoch: string;
@@ -96,6 +94,7 @@ export type ModelRegistryBase = {
 export type ModelArtifact = ModelRegistryBase & {
   uri?: string;
   state?: ModelArtifactState;
+  author?: string;
   modelFormatName?: string;
   storageKey?: string;
   storagePath?: string;
@@ -106,11 +105,13 @@ export type ModelArtifact = ModelRegistryBase & {
 
 export type ModelVersion = ModelRegistryBase & {
   state?: ModelState;
+  author?: string;
   registeredModelId: string;
 };
 
 export type RegisteredModel = ModelRegistryBase & {
   state?: ModelState;
+  owner?: string;
 };
 
 export type InferenceService = ModelRegistryBase & {

diff --git a/frontend/src/pages/modelRegistry/screens/ModelVersions/ModelDetailsView.tsx b/frontend/src/pages/modelRegistry/screens/ModelVersions/ModelDetailsView.tsx
@@ -82,7 +82,7 @@ const ModelDetailsView: React.FC<ModelDetailsViewProps> = ({ registeredModel: rm
             </ClipboardCopy>
           </DashboardDescriptionListGroup>
           <DashboardDescriptionListGroup title="Owner">
-            <Text data-testid="registered-model-owner">{rm.author || '-'}</Text>
+            <Text data-testid="registered-model-owner">{rm.owner || '-'}</Text>
           </DashboardDescriptionListGroup>
           <DashboardDescriptionListGroup
             title="Last modified at"

diff --git a/frontend/src/pages/modelRegistry/screens/RegisterModel/utils.ts b/frontend/src/pages/modelRegistry/screens/RegisterModel/utils.ts
@@ -33,7 +33,7 @@ export const registerModel = async (
       name: formData.modelName,
       description: formData.modelDescription,
       customProperties: {},
-      author,
+      owner: author,
       state: ModelState.LIVE,
     },
   );

diff --git a/frontend/src/pages/modelRegistry/screens/__tests__/utils.spec.ts b/frontend/src/pages/modelRegistry/screens/__tests__/utils.spec.ts
@@ -270,7 +270,6 @@ describe('getPatchBody', () => {
   it('returns a given RegisteredModel with id/name/timestamps removed, customProperties updated and other values unchanged', () => {
     const registeredModel = mockRegisteredModel({
       id: '1',
-      author: 'Author 1',
       owner: 'Author 1',
       name: 'test-model',
       description: 'Description here',
@@ -288,7 +287,6 @@ describe('getPatchBody', () => {
     );
     expect(result).toEqual({
       description: 'Description here',
-      author: 'Author 1',
       customProperties: {
         label1: { string_value: '', metadataType: ModelRegistryMetadataType.STRING },
       },