PR feedback from Jeff, merge into one pipeline component factory

frontend/src/concepts/topology/factories.ts

@@ -29,24 +29,8 @@ export const pipelineComponentFactory: ComponentFactory = (kind, type) => {
       return SpacerNode;
     case DEFAULT_EDGE_TYPE:
       return PipelineTaskEdge;
-    default:
-      return undefined;
-  }
-};
-
-export const pipelineGroupsComponentFactory: ComponentFactory = (kind, type) => {
-  if (kind === ModelKind.graph) {
-    return withPanZoom()(GraphComponent);
-  }
-  switch (type) {
     case EXECUTION_TASK_NODE_TYPE:
       return withSelection()(PipelineDefaultTaskGroup);
-    case DEFAULT_TASK_NODE_TYPE:
-      return withSelection()(StandardTaskNode);
-    case ICON_TASK_NODE_TYPE:
-      // eslint-disable-next-line @typescript-eslint/ban-ts-comment
-      // @ts-ignore
-      return withSelection()(ArtifactTaskNode);
     default:
       return undefined;
   }

frontend/src/concepts/topology/useTopologyController.ts

@@ -8,7 +8,7 @@ import {
   Visualization,
 } from '@patternfly/react-topology';
 import pipelineElementFactory from '@patternfly/react-topology/dist/esm/pipelines/elements/pipelineElementFactory';
-import { pipelineComponentFactory, pipelineGroupsComponentFactory } from './factories';
+import { pipelineComponentFactory } from './factories';
 import { PIPELINE_LAYOUT, PIPELINE_NODE_SEPARATION_VERTICAL } from './const';
 
 const useTopologyController = (graphId: string): Visualization | null => {
@@ -19,7 +19,6 @@ const useTopologyController = (graphId: string): Visualization | null => {
     visualizationController.setFitToScreenOnLayout(true);
     visualizationController.registerElementFactory(pipelineElementFactory);
     visualizationController.registerComponentFactory(pipelineComponentFactory);
-    visualizationController.registerComponentFactory(pipelineGroupsComponentFactory);
     visualizationController.registerLayoutFactory(
       (type: string, graph: Graph): Layout | undefined =>
         new PipelineDagreGroupsLayout(graph, {