Fix useGroups & update ssar check to patch

opendatahub-io · Dec 16, 2024 · b17a818 · b17a818
1 parent bcf15a2
commit b17a818
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/frontend/src/api/k8s/groups.ts b/frontend/src/api/k8s/groups.ts
@@ -26,9 +26,12 @@ export const useGroups = (): CustomWatchK8sResult<GroupKind[]> => {
   const [groupData, loaded, error] = useK8sWatchResourceList<GroupKind[]>(initResource, GroupModel);
 
   return React.useMemo(() => {
+    if (!accessReviewLoaded) {
+      return [[], false, undefined];
+    }
     if (!allowList) {
       return [[], true, undefined];
     }
     return [groupData, loaded, error];
-  }, [error, groupData, loaded, allowList]);
+  }, [accessReviewLoaded, allowList, groupData, loaded, error]);
 };
diff --git a/frontend/src/concepts/userConfigs/utils.ts b/frontend/src/concepts/userConfigs/utils.ts
@@ -6,7 +6,7 @@ const authCheck: AccessReviewResourceAttributes = {
   group: 'services.platform.opendatahub.io',
   resource: AuthModel.plural,
   name: AUTH_SINGLETON_NAME,
-  verb: 'update', // If they can get the data but not updated, we can assume they cannot access it
+  verb: 'patch', // If they can get the data but not update it, we can assume they cannot access it
 };
 
 export const useDoesUserHaveAuthAccess = (): ReturnType<typeof useAccessReview> =>