Dashboard shows cached pipeline steps in gray (no info about what it …

…means)
opendatahub-io · Jun 11, 2024 · aeeb8ab · aeeb8ab
1 parent f7c9979
commit aeeb8ab
Show file tree

Hide file tree

Showing 5 changed files with 14 additions and 7 deletions.
diff --git a/frontend/package-lock.json b/frontend/package-lock.json
diff --git a/frontend/package.json b/frontend/package.json
@@ -65,7 +65,7 @@
     "@patternfly/react-styles": "^5.2.1",
     "@patternfly/react-table": "^5.2.1",
     "@patternfly/react-tokens": "^5.2.1",
-    "@patternfly/react-topology": "^5.4.0-prerelease.1",
+    "@patternfly/react-topology": "^5.4.0-prerelease.6",
     "@patternfly/react-virtualized-extension": "^5.0.0",
     "@types/classnames": "^2.3.1",
     "axios": "^1.6.4",

diff --git a/frontend/src/concepts/pipelines/topology/__tests__/parseUtils.spec.ts b/frontend/src/concepts/pipelines/topology/__tests__/parseUtils.spec.ts
@@ -287,7 +287,7 @@ describe('pipeline topology parseUtils', () => {
       { state: RuntimeStateKF.SKIPPED, status: RunStatus.Skipped },
       { state: RuntimeStateKF.SUCCEEDED, status: RunStatus.Succeeded },
       { state: ExecutionStateKF.CANCELED, status: RunStatus.Cancelled },
-      { state: ExecutionStateKF.CACHED, status: RunStatus.Skipped },
+      { state: ExecutionStateKF.CACHED, status: RunStatus.Succeeded },
       { state: ExecutionStateKF.COMPLETE, status: RunStatus.Succeeded },
       { state: ExecutionStateKF.FAILED, status: RunStatus.Failed },
       { state: ExecutionStateKF.RUNNING, status: RunStatus.Running },

diff --git a/frontend/src/concepts/pipelines/topology/parseUtils.ts b/frontend/src/concepts/pipelines/topology/parseUtils.ts
@@ -301,8 +301,8 @@ export const translateStatusForNode = (
       return RunStatus.InProgress;
     case ExecutionStateKF.COMPLETE:
     case RuntimeStateKF.SUCCEEDED:
-      return RunStatus.Succeeded;
     case ExecutionStateKF.CACHED:
+      return RunStatus.Succeeded;
     case RuntimeStateKF.SKIPPED:
       return RunStatus.Skipped;
     case RuntimeStateKF.RUNTIME_STATE_UNSPECIFIED:

diff --git a/frontend/src/concepts/topology/customNodes/StandardTaskNode.tsx b/frontend/src/concepts/topology/customNodes/StandardTaskNode.tsx
@@ -12,7 +12,9 @@ import {
   WithContextMenuProps,
   WithSelectionProps,
 } from '@patternfly/react-topology';
+import { AngleDoubleRightIcon } from '@patternfly/react-icons';
 import { PipelineNodeModelExpanded } from '~/concepts/topology/types';
+import { ExecutionStateKF } from '~/concepts/pipelines/kfTypes';
 
 type StandardTaskNodeProps = {
   element: GraphElement<PipelineNodeModelExpanded>;
@@ -45,6 +47,11 @@ const StandardTaskNode: React.FunctionComponent<StandardTaskNodeProps> = ({
         selected={selected}
         scaleNode={hover && detailsLevel !== ScaleDetailsLevel.high}
         status={data?.runStatus}
+        customStatusIcon={
+          data?.pipelineTask.status?.state === ExecutionStateKF.CACHED ? (
+            <AngleDoubleRightIcon />
+          ) : undefined
+        }
         hideDetailsAtMedium
         hiddenDetailsShownStatuses={[
           RunStatus.Succeeded,