Merge remote-tracking branch 'opendatahub-io/main' into f/ds-projects

.github/pull_request_template.md

@@ -28,7 +28,7 @@ Self checklist (all need to be checked):
 If you have UI changes: 
 <!--- You can ignore these if you are doing manifest, backend, internal logic, etc changes; aka non-UI / visual changes -->
 - [ ] Included any necessary screenshots or gifs if it was a UI change.
-- [ ] Included tags to the UX team if it was a UI/UX change.
+- [ ] Included tags to the UX team if it was a UI/UX change (find relevant UX in the [SMEs](https://github.com/opendatahub-io/odh-dashboard/tree/main/docs/smes.md) section).
 
 After the PR is posted & before it merges:
 - [ ] The developer has tested their solution on a cluster by using the image produced by the PR to `main`

.github/workflows/pull_request.yml

@@ -12,7 +12,7 @@ jobs:
     steps:
       - uses: actions/checkout@v3
       - name: Setup Node.js ${{ matrix.node-version }}
-        uses: actions/setup-node@v3.7.0
+        uses: actions/setup-node@v3.8.1
         with:
           node-version: ${{ matrix.node-version }}
       - name: Node.js modules cache, repository

OWNERS

@@ -1,8 +1,17 @@
 approvers:
 - andrewballantyne
+- lucferbux
+- alexcreasy
+- christianvogt
 
 reviewers:
-- DaoDaoNoCode
-- lucferbux
-- Gkrumbach07
 - alexcreasy
+- christianvogt
+- uidoyen
+- Gkrumbach07
+- lucferbux
+- DaoDaoNoCode
+- manaswinidas
+- pnaik1
+- ppadti
+- dpanshug

docs/smes.md

@@ -0,0 +1,65 @@
+# Subject Matter Experts (SMEs)
+
+A given subject matter expert is not necessarily the most knowledgeable in the area, but they are the one who probably knows the most about it when it was originally done or has a responsibility to expand their knowledge to know about the area going forward. Contacting them first will help with delegation of responsibilities at the Dashboard level.
+
+This will detail out former (or current) feature leads, area leads (has a responsibility to understand the area), as well as any other notable position in relation to the area. If you need to talk to someone or ping someone for a review, this information should help you determine who.
+
+Below there will be some terms like “previous” and “backup”, these are for additional context. The way you can read each are as follows:
+- **previous** – the initial SME in the area. If you need legacy context, this person may be able to help
+- **backup** – a good person to lean on if there is a need for any 2nd opinions, for bouncing ideas off of, or any larger discussion about direction
+- **and** – Ping both during conversations – could be onboarding, could be a need to share information, best get both people involved at the same time
+
+General Dashboard ownership
+- Infrastructure / direction
+    - Architect: `Andrew` ([andrewballantyne])
+    - General UX: `Kyle` ([kywalker-rh])
+    - App Text: `Katie` ([kaedward])
+- Testing (Integration, Unit, etc)
+    - Area lead: `Gage` ([Gkrumbach07])
+- Performance
+    - Area lead: `Lucas` ([lucferbux])
+
+Dashboard features
+- Data Science Projects
+    - Feature lead: `Andrew` ([andrewballantyne])
+    - UX: `Kyle` ([kywalker-rh]) **and** `Kun` ([xianli123])
+- Data Science Pipelines
+    - Feature lead: `Andrew` ([andrewballantyne])
+    - UX: `Yan` ([yannnz])
+        - Previous: `Kyle` ([kywalker-rh])
+- Explainability, Bias
+    - Feature lead: `Alex` ([alexcreasy])
+    - UX: `Vince` ([vconzola])
+- Model Serving (Custom runtimes, general Model Serving)
+    - Feature lead: `Lucas` ([lucferbux])
+    - UX: `Vince` ([vconzola])
+- Model Serving - Performance metrics
+    - Feature lead: `Andrew` ([andrewballantyne])
+    - UX: `Vince` ([vconzola])
+- BYON - Custom Notebook Images
+    - Feature lead: `Juntao` ([DaoDaoNoCode])
+        - Backup: `Andrew` ([andrewballantyne])
+    - UX: `Vince` ([vconzola])
+- Habana / Accelerators
+    - Feature lead: `Gage` ([Gkrumbach07]);
+        - Backup: `Andrew` ([andrewballantyne])
+    - UX: `Yan` ([yannnz])
+- Model Registry
+    - Feature lead: TBD
+    - UX: `Sim` ([simrandhaliw])  **and** `Haley` ([yih-wang])
+
+<!-- Developers -->
+[andrewballantyne]: https://github.com/andrewballantyne
+[Gkrumbach07]: https://github.com/Gkrumbach07
+[lucferbux]: https://github.com/lucferbux
+[alexcreasy]: https://github.com/alexcreasy
+[DaoDaoNoCode]: https://github.com/DaoDaoNoCode
+
+<!-- UX -->
+[kywalker-rh]: https://github.com/kywalker-rh
+[kaedward]: https://github.com/kaedward
+[xianli123]: https://github.com/xianli123
+[vconzola]: https://github.com/vconzola
+[yannnz]: https://github.com/yannnz
+[simrandhaliw]: https://github.com/simrandhaliw
+[yih-wang]: https://github.com/yih-wang

frontend/config/webpack.common.js

@@ -219,7 +219,9 @@ module.exports = (env) => {
           },
         ],
       }),
-      new MonacoWebpackPlugin(),
+      new MonacoWebpackPlugin({
+        languages: ['yaml'],
+      }),
     ],
     resolve: {
       extensions: ['.js', '.ts', '.tsx', '.jsx'],

frontend/src/app/App.tsx

@@ -26,6 +26,7 @@ import { AppContext } from './AppContext';
 import { useApplicationSettings } from './useApplicationSettings';
 import TelemetrySetup from './TelemetrySetup';
 import { logout } from './appUtils';
+import QuickStarts from './QuickStarts';
 
 import './App.scss';
 
@@ -99,7 +100,9 @@ const App: React.FC = () => {
       >
         <ErrorBoundary>
           <ProjectsContextProvider>
-            <AppRoutes />
+            <QuickStarts>
+              <AppRoutes />
+            </QuickStarts>
           </ProjectsContextProvider>
           <ToastNotifications />
           <TelemetrySetup />

frontend/src/concepts/pipelines/content/pipelinesDetails/PipelineDetailsYAML.tsx

@@ -33,6 +33,7 @@ const PipelineDetailsYAML: React.FC<PipelineDetailsYAMLProps> = ({ filename, con
       isCopyEnabled
       isLanguageLabelVisible
       language={Language.yaml}
+      isReadOnly
     />
   );
 };

frontend/src/concepts/pipelines/topology/core/TaskEdge.tsx

@@ -0,0 +1,46 @@
+import * as React from 'react';
+import { css } from '@patternfly/react-styles';
+import styles from '@patternfly/react-styles/css/components/Topology/topology-components';
+import {
+  observer,
+  Edge,
+  integralShapePath,
+  DEFAULT_SPACER_NODE_TYPE,
+  ConnectorArrow,
+} from '@patternfly/react-topology';
+interface TaskEdgeProps {
+  element: Edge;
+  className?: string;
+  nodeSeparation?: number;
+}
+
+const TaskEdge: React.FunctionComponent<TaskEdgeProps> = ({
+  element,
+  className,
+  nodeSeparation,
+}) => {
+  const startPoint = element.getStartPoint();
+  const endPoint = element.getEndPoint();
+  const groupClassName = css(styles.topologyEdge, className);
+  const startIndent: number = element.getData()?.indent || 0;
+
+  return (
+    <g data-test-id="task-handler" className={groupClassName}>
+      <path
+        fillOpacity={0}
+        d={integralShapePath(startPoint, endPoint, startIndent, nodeSeparation)}
+        shapeRendering="geometricPrecision"
+      />
+
+      {element.getTarget().getType() !== DEFAULT_SPACER_NODE_TYPE ? (
+        <ConnectorArrow
+          className={styles.topologyEdge}
+          startPoint={endPoint.clone().translate(-1, 0)}
+          endPoint={endPoint}
+        />
+      ) : null}
+    </g>
+  );
+};
+
+export default observer(TaskEdge);

frontend/src/concepts/pipelines/topology/core/factories.ts

@@ -6,12 +6,11 @@ import {
   GraphComponent,
   ModelKind,
   SpacerNode,
-  TaskEdge,
   withPanZoom,
   withSelection,
 } from '@patternfly/react-topology';
 import StandardTaskNode from '~/concepts/pipelines/topology/core/customNodes/StandardTaskNode';
-
+import TaskEdge from './TaskEdge';
 // Topology gap... their types have issues with Strict TS mode
 // eslint-disable-next-line @typescript-eslint/ban-ts-comment
 // @ts-ignore

frontend/src/pages/enabledApplications/EnabledApplications.tsx

@@ -5,7 +5,6 @@ import { useWatchComponents } from '~/utilities/useWatchComponents';
 import { OdhApplication } from '~/types';
 import ApplicationsPage from '~/pages/ApplicationsPage';
 import OdhAppCard from '~/components/OdhAppCard';
-import QuickStarts from '~/app/QuickStarts';
 import { fireTrackingEvent } from '~/utilities/segmentIOUtils';
 
 const description = `Launch your enabled applications, view documentation, or get started with quick start instructions and tasks.`;
@@ -74,13 +73,7 @@ const EnabledApplications: React.FC = () => {
   }, [components, loaded]);
 
   return (
-    <QuickStarts>
-      <EnabledApplicationsInner
-        loaded={loaded}
-        components={sortedComponents}
-        loadError={loadError}
-      />
-    </QuickStarts>
+    <EnabledApplicationsInner loaded={loaded} components={sortedComponents} loadError={loadError} />
   );
 };
 

frontend/src/pages/learningCenter/LearningCenter.tsx

@@ -9,7 +9,6 @@ import { useWatchDocs } from '~/utilities/useWatchDocs';
 import { useBrowserStorage } from '~/components/browserStorage';
 import { useQueryParams } from '~/utilities/useQueryParams';
 import ApplicationsPage from '~/pages/ApplicationsPage';
-import QuickStarts from '~/app/QuickStarts';
 import { DOC_LINK, ODH_PRODUCT_NAME } from '~/utilities/const';
 import { combineCategoryAnnotations } from '~/utilities/utils';
 import { useDeepCompareMemoize } from '~/utilities/useDeepCompareMemoize';
@@ -230,10 +229,4 @@ export const LearningCenter: React.FC = () => {
   );
 };
 
-const LearningCenterWrapper: React.FC = () => (
-  <QuickStarts>
-    <LearningCenter />
-  </QuickStarts>
-);
-
-export default LearningCenterWrapper;
+export default LearningCenter;