Dashboard shows cached pipeline steps in gray (no info about what it …

…means)
opendatahub-io · Jun 12, 2024 · 68f4f14 · 68f4f14
1 parent 7725a1f
commit 68f4f14
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 2 deletions.
diff --git a/frontend/src/concepts/pipelines/topology/__tests__/parseUtils.spec.ts b/frontend/src/concepts/pipelines/topology/__tests__/parseUtils.spec.ts
@@ -283,7 +283,7 @@ describe('pipeline topology parseUtils', () => {
       { state: RuntimeStateKF.SKIPPED, status: RunStatus.Skipped },
       { state: RuntimeStateKF.SUCCEEDED, status: RunStatus.Succeeded },
       { state: ExecutionStateKF.CANCELED, status: RunStatus.Cancelled },
-      { state: ExecutionStateKF.CACHED, status: RunStatus.Skipped },
+      { state: ExecutionStateKF.CACHED, status: RunStatus.Succeeded },
       { state: ExecutionStateKF.COMPLETE, status: RunStatus.Succeeded },
       { state: ExecutionStateKF.FAILED, status: RunStatus.Failed },
       { state: ExecutionStateKF.RUNNING, status: RunStatus.Running },

diff --git a/frontend/src/concepts/topology/customNodes/StandardTaskNode.tsx b/frontend/src/concepts/topology/customNodes/StandardTaskNode.tsx
@@ -12,7 +12,9 @@ import {
   WithContextMenuProps,
   WithSelectionProps,
 } from '@patternfly/react-topology';
+import { AngleDoubleRightIcon } from '@patternfly/react-icons';
 import { PipelineNodeModelExpanded } from '~/concepts/topology/types';
+import { ExecutionStateKF } from '~/concepts/pipelines/kfTypes';
 
 type StandardTaskNodeProps = {
   element: GraphElement<PipelineNodeModelExpanded>;
@@ -29,6 +31,14 @@ const StandardTaskNode: React.FunctionComponent<StandardTaskNodeProps> = ({
   const [hover, hoverRef] = useHover();
   const detailsLevel = element.getGraph().getDetailsLevel();
 
+  // Set the cached node status to Succeeded
+  const getNodeStatus = () => {
+    if (data?.pipelineTask.status?.state === ExecutionStateKF.CACHED) {
+      return RunStatus.Succeeded;
+    }
+    return data?.runStatus;
+  };
+
   const whenDecorator = data?.pipelineTask.whenStatus ? (
     <WhenDecorator
       element={element}
@@ -44,7 +54,12 @@ const StandardTaskNode: React.FunctionComponent<StandardTaskNodeProps> = ({
         onSelect={onSelect}
         selected={selected}
         scaleNode={hover && detailsLevel !== ScaleDetailsLevel.high}
-        status={data?.runStatus}
+        status={getNodeStatus()}
+        customStatusIcon={
+          data?.pipelineTask.status?.state === ExecutionStateKF.CACHED ? (
+            <AngleDoubleRightIcon />
+          ) : undefined
+        }
         hideDetailsAtMedium
         hiddenDetailsShownStatuses={[
           RunStatus.Succeeded,