Merge pull request #2934 from rsun19/default-cypress-vars

configured default environment for cypress
opendatahub-io · Jun 24, 2024 · 3f0cf84 · 3f0cf84
2 parents 39ec5ca + 4639ee1
commit 3f0cf84
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 2 deletions.
diff --git a/frontend/.eslintrc b/frontend/.eslintrc
@@ -327,6 +327,22 @@
           }
         ]
       }
+    },
+    {
+      "files": ["src/__tests__/cypress/**"],
+      "rules": {
+        "no-restricted-syntax": [
+          "error",
+          {
+            "selector": "Literal[value=/\\bRed Hat OpenShift AI\\b/i],JSXText[value=/\\bRed Hat OpenShift AI\\b/i]",
+            "message": "Do not hard code product name `Red Hat OpenShift AI`. Use `Cypress.env('ODH_PRODUCT_NAME')` instead."
+          },
+          {
+            "selector": "Literal[value=/\\bOpen Data Hub\\b/i],JSXText[value=/\\bOpen Data Hub\\b/i]",
+            "message": "Do not hard code product name `Open Data Hub`. Use `Cypress.env('ODH_PRODUCT_NAME')` instead."
+          }
+        ]
+      }
     }
   ]
 }
diff --git a/frontend/src/__tests__/cypress/cypress/pages/components/JupyterCard.ts b/frontend/src/__tests__/cypress/cypress/pages/components/JupyterCard.ts
@@ -10,7 +10,7 @@ export class JupyterCard extends Card {
       .findByTestId('tooltip-img')
       .trigger('mouseenter')
       .then(() => {
-        cy.findByText('Open Data Hub certified and supported');
+        cy.findByText(`${Cypress.env('ODH_PRODUCT_NAME')} certified and supported`);
       });
   }
 

diff --git a/frontend/src/__tests__/cypress/cypress/tests/mocked/application.cy.ts b/frontend/src/__tests__/cypress/cypress/tests/mocked/application.cy.ts
@@ -30,7 +30,7 @@ describe('Application', () => {
     const applicationLauncher = appChrome.getApplicationLauncher();
     applicationLauncher.toggleAppLauncherButton();
     const applicationLauncherMenuGroup = applicationLauncher.getApplicationLauncherMenuGroup(
-      'Open Data Hub Applications',
+      `${Cypress.env('ODH_PRODUCT_NAME')} Applications`,
     );
     applicationLauncherMenuGroup.shouldHaveApplicationLauncherItem('OpenShift Cluster Manager');
     applicationLauncher.toggleAppLauncherButton();