Merge pull request #2955 from jpuzz0/RHOAIENG-8583

[RHOAIENG-8583] Remove the disabled 'Create schedule' button when in an archived experiment
opendatahub-io · Jul 3, 2024 · 38ba83d · 38ba83d
2 parents d5581e4 + 72709aa
commit 38ba83d
Show file tree

Hide file tree

Showing 3 changed files with 21 additions and 13 deletions.
diff --git a/frontend/src/__tests__/cypress/cypress/tests/mocked/pipelines/experiments.cy.ts b/frontend/src/__tests__/cypress/cypress/tests/mocked/pipelines/experiments.cy.ts
@@ -325,10 +325,10 @@ describe('Runs page for archived experiment', () => {
     pipelineRunsGlobal.findRestoreRunButton().should('have.class', 'pf-m-aria-disabled');
   });
 
-  it('has create schedule button disabled on schedules tab', () => {
+  it('has no create schedule button on schedules tab', () => {
     pipelineRunsGlobal.findSchedulesTab().click();
     pipelineRunJobTable.getRowByName('Test job').findCheckbox().click();
-    pipelineRunsGlobal.findScheduleRunButton().should('have.class', 'pf-m-aria-disabled');
+    pipelineRunsGlobal.findScheduleRunButton().should('not.exist');
   });
 });
 

diff --git a/frontend/src/concepts/pipelines/content/tables/pipelineRunJob/PipelineRunJobTableToolbar.tsx b/frontend/src/concepts/pipelines/content/tables/pipelineRunJob/PipelineRunJobTableToolbar.tsx
@@ -6,6 +6,7 @@ import { FilterOptions } from '~/concepts/pipelines/content/tables/usePipelineFi
 import PipelineVersionSelect from '~/concepts/pipelines/content/pipelineSelector/CustomPipelineVersionSelect';
 import { PipelineRunVersionsContext } from '~/pages/pipelines/global/runs/PipelineRunVersionsContext';
 import CreateScheduleButton from '~/pages/pipelines/global/runs/CreateScheduleButton';
+import { useContextExperimentArchived as useIsExperimentArchived } from '~/pages/pipelines/global/experiments/ExperimentRunsContext';
 
 export type FilterProps = Pick<
   React.ComponentProps<typeof PipelineFilterBar>,
@@ -21,6 +22,7 @@ const PipelineRunJobTableToolbar: React.FC<PipelineRunJobTableToolbarProps> = ({
   ...toolbarProps
 }) => {
   const { versions } = React.useContext(PipelineRunVersionsContext);
+  const isExperimentArchived = useIsExperimentArchived();
   const { pipelineVersionId } = useParams();
 
   const options = {
@@ -53,9 +55,12 @@ const PipelineRunJobTableToolbar: React.FC<PipelineRunJobTableToolbarProps> = ({
         ),
       }}
     >
-      <ToolbarItem>
-        <CreateScheduleButton />
-      </ToolbarItem>
+      {!isExperimentArchived && (
+        <ToolbarItem>
+          <CreateScheduleButton />
+        </ToolbarItem>
+      )}
+
       <ToolbarItem data-testid="job-table-toolbar-item">{dropdownActions}</ToolbarItem>
     </PipelineFilterBar>
   );

diff --git a/frontend/src/pages/pipelines/global/runs/ScheduledRuns.tsx b/frontend/src/pages/pipelines/global/runs/ScheduledRuns.tsx
@@ -16,12 +16,13 @@ import { ExclamationCircleIcon, PlusCircleIcon } from '@patternfly/react-icons';
 import PipelineRunJobTable from '~/concepts/pipelines/content/tables/pipelineRunJob/PipelineRunJobTable';
 import { usePipelineScheduledRunsTable } from '~/concepts/pipelines/content/tables/pipelineRunJob/usePipelineRunJobTable';
 import CreateScheduleButton from '~/pages/pipelines/global/runs/CreateScheduleButton';
+import { useContextExperimentArchived as useIsExperimentArchived } from '~/pages/pipelines/global/experiments/ExperimentRunsContext';
 
 const ScheduledRuns: React.FC = () => {
   const { experimentId, pipelineVersionId } = useParams();
-
   const [[{ items: jobs, totalSize }, loaded, error], { initialLoaded, ...tableProps }] =
     usePipelineScheduledRunsTable({ experimentId, pipelineVersionId });
+  const isExperimentArchived = useIsExperimentArchived();
 
   if (error) {
     return (
@@ -56,15 +57,17 @@ const ScheduledRuns: React.FC = () => {
         />
 
         <EmptyStateBody>
-          Schedules dictate when and how many times a run is executed. To get started, create a
-          schedule.
+          Schedules dictate when and how many times a run is executed.{' '}
+          {!isExperimentArchived && 'To get started, create a schedule.'}
         </EmptyStateBody>
 
-        <EmptyStateFooter>
-          <EmptyStateActions>
-            <CreateScheduleButton />
-          </EmptyStateActions>
-        </EmptyStateFooter>
+        {!isExperimentArchived && (
+          <EmptyStateFooter>
+            <EmptyStateActions>
+              <CreateScheduleButton />
+            </EmptyStateActions>
+          </EmptyStateFooter>
+        )}
       </EmptyState>
     );
   }