Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync 2024a branch with main branch #658

Merged
merged 12 commits into from
Aug 2, 2024

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Aug 1, 2024

🤖 This is an automated Pull Request created by /.github/workflows/sync-branches-through-pr.yml.

It merges all commits from main branch into 2024a branch.

⚠️ IMPORTANT NOTE: Remember to delete the sync__main__2024a__20240801171122 branch after merging the changes.

caponetto and others added 11 commits July 24, 2024 11:03
- Pinned kfp-tekton due the requirements changing pyyaml.
- Pinned rest of the packages for dependency resolutions.

Signed-off-by: Harshad Reddy Nalla <[email protected]>
[Digest Updater Action] Update Runtimes Images
Signed-off-by: Harshad Reddy Nalla <[email protected]>
Co-authored-by: Jan Stourac <[email protected]>
* Incorporate rocm-pytorch and rocm-tensorflow runtime images

* Commit autogenerated changes from the  to update the build-notebooks.yaml

* Rename references of amd to rocm as more proper naming
Pinned down jupyter-server-proxy for cve fixes
chore(ci): Run Trivy scan `fs` instead of `image` for rocm+pytorch image due to resource constraints
chore(ci): Sanitize ref name before using it as container tag
Upgrade codeflare-sdk 0.18.0 for py3.9 content
Copy link
Contributor

openshift-ci bot commented Aug 1, 2024

Hi @github-actions[bot]. Thanks for your PR.

I'm waiting for a opendatahub-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@harshad16
Copy link
Member

/ok-to-test
/lgtm
/approve

👍

Copy link
Contributor

openshift-ci bot commented Aug 1, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: harshad16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Aug 1, 2024
Copy link
Contributor

openshift-ci bot commented Aug 1, 2024

@github-actions[bot]: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/images ed2742a link true /test images

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@harshad16
Copy link
Member

Merging to get the build ready.

@harshad16 harshad16 merged commit bd6dd09 into 2024a Aug 2, 2024
65 of 67 checks passed
@harshad16 harshad16 deleted the sync__main__2024a__20240801171122 branch August 2, 2024 11:34
@jstourac
Copy link
Member

jstourac commented Aug 5, 2024

This is missing at least #656, is it intentional?

Edit: I see, this was merged before the other one was merged. Sorry for confusion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants