-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RHOAIENG-7525: Build opendatahub-io/notebooks in GitHub Action with caching #543
RHOAIENG-7525: Build opendatahub-io/notebooks in GitHub Action with caching #543
Conversation
Hi @jiridanek. Thanks for your PR. I'm waiting for a opendatahub-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
dc5a25a
to
180517a
Compare
Here's how it runs, https://github.com/jiridanek/notebooks/actions/runs/9206160094 |
6e21ada
to
5c3ccae
Compare
2bbd779
to
6243293
Compare
/ok-to-test |
fe9e503
to
e0a43e7
Compare
e0a43e7
to
b4dd31d
Compare
/label tide/merge-method-squash |
@jiridanek: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
41bc50d
to
23911fb
Compare
/override ci/prow/images |
@jiridanek: jiridanek unauthorized: /override is restricted to Repo administrators, approvers in top level OWNERS file, and the following github teams:. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
fa89076
to
0a78449
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work, @jiridanek! I finally had the time to take a look at this, and I don't have any comments to add. Very neat work!
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: atheo89 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test notebook-jupyter-intel-pyt-ubi9-python-3-9-pr-image-mirror |
/override ci/prow/notebooks-e2e-tests as it is failing on issue unrelated to GitHub Actions |
@jiridanek: jiridanek unauthorized: /override is restricted to Repo administrators, approvers in top level OWNERS file, and the following github teams:. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/override ci/prow/notebooks-e2e-tests |
@atheo89: Overrode contexts on behalf of atheo89: ci/prow/notebooks-e2e-tests In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/retest |
…aching Signed-off-by: Jiri Daněk <[email protected]>
0a78449
to
5c4029b
Compare
New changes are detected. LGTM label has been removed. |
/override ci/prow/notebooks-e2e-tests |
@atheo89: Overrode contexts on behalf of atheo89: ci/prow/notebooks-e2e-tests In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
4d4841f
into
opendatahub-io:main
https://issues.redhat.com/browse/RHOAIENG-7525
Description
build only images that changed compared to the PR target branch and images that depend on theseHow Has This Been Tested?
See GHA run
Merge criteria: