Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update of Anaconda deps... finally #377

Merged
merged 1 commit into from
Dec 6, 2023

Conversation

Xaenalt
Copy link
Member

@Xaenalt Xaenalt commented Nov 29, 2023

That's right, it's the moment you've all been waiting for, finally an upgrade of the Anaconda deps xD

@openshift-ci openshift-ci bot requested review from atheo89 and harshad16 November 29, 2023 21:50
@Xaenalt
Copy link
Member Author

Xaenalt commented Nov 29, 2023

@trujillm behold!

@harshad16
Copy link
Member

@Xaenalt can you share what command you used to set this up ?
as it would help us do this in future as well

@Xaenalt
Copy link
Member Author

Xaenalt commented Nov 30, 2023

Yep
For the base image, it's just conda env export -p /opt/app-root > environment.yml after installation/update of packages. That just freezes the base deps

For the datascience image, it was running:

conda install -c conda-forge $(cat environment.in)
conda env export -p /opt/app-root > environment.yml

The environment.in was generated by just taking the pipfile's Packages section and reformatting it (and chopping the last digit of the version, since they may not always 1:1 match wit the ones available, and debugging that kfp-tekton was an unsatisfiable package version with all the others

@harshad16
Copy link
Member

Yep For the base image, it's just conda env export -p /opt/app-root > environment.yml after installation/update of packages. That just freezes the base deps

what commands did you use for installation and update ?

For the datascience image, it was running:

conda install -c conda-forge $(cat environment.in)
conda env export -p /opt/app-root > environment.yml

The environment.in was generated by just taking the pipfile's Packages section and reformatting it (and chopping the last digit of the version, since they may not always 1:1 match wit the ones available, and debugging that kfp-tekton was an unsatisfiable package version with all the others

ack, did you update environment.yml for data-science as well.

@Xaenalt
Copy link
Member Author

Xaenalt commented Nov 30, 2023

Yep, environment.yml is updated for both, also some other good news is @trujillm will be taking over the maintenance of these in the future, as well as writing some of the automation I wasn't able to figure out

@Xaenalt
Copy link
Member Author

Xaenalt commented Nov 30, 2023

For install and update, I just copied the block in the Dockerfile for install:

ANACONDA_INSTALLER_NAME=Miniconda3-latest-Linux-x86_64.sh
curl -O "https://repo.anaconda.com/miniconda/${ANACONDA_INSTALLER_NAME}"
chmod +x ${ANACONDA_INSTALLER_NAME}
./${ANACONDA_INSTALLER_NAME} -b -p /opt/anaconda3
rm -f ${ANACONDA_INSTALLER_NAME}

Followed by

/opt/anaconda3/bin/conda env create --file environment.yml -p /opt/app-root && \
source /opt/anaconda3/bin/activate /opt/app-root && \
conda update --all -y && \
/opt/anaconda3/bin/conda env export > environment.yml

@trujillm
Copy link
Contributor

trujillm commented Dec 5, 2023

@harshad16 do you know when this will get merged?

Copy link
Member

@harshad16 harshad16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

thanks for the excellent work 💯

Copy link
Contributor

openshift-ci bot commented Dec 6, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: harshad16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Dec 6, 2023
@openshift-merge-bot openshift-merge-bot bot merged commit 9c3edfd into opendatahub-io:main Dec 6, 2023
1 check passed
@jstourac
Copy link
Member

jstourac commented Dec 7, 2023

Thank you, Sean, for fixing this for us! 🚀 I suppose that this is tied with the #195 so mentioning it here for the reference.

harshad16 added a commit to jstourac/notebooks that referenced this pull request Sep 11, 2024
[GHA] Pin kustomize version we use in our test to the particular version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants