Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs in favor of the 2023b release #281

Merged
merged 1 commit into from
Oct 26, 2023

Conversation

atheo89
Copy link
Member

@atheo89 atheo89 commented Oct 24, 2023

Update docs in favor of the 2023b release

Description

This pull request updates the Docs folder to match the latest content from our Wiki page, reflecting the most recent changes.

Links to the changes:

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@atheo89 atheo89 changed the title Update docs in favor of the 2023b release [WIP] Update docs in favor of the 2023b release Oct 24, 2023
@atheo89 atheo89 changed the title [WIP] Update docs in favor of the 2023b release Update docs in favor of the 2023b release Oct 24, 2023
Copy link
Member

@jstourac jstourac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Adriana, I put some comments there 🙂

docs/developer-guide.md Show resolved Hide resolved
docs/developer-guide.md Outdated Show resolved Hide resolved
docs/developer-guide.md Outdated Show resolved Hide resolved
docs/developer-guide.md Outdated Show resolved Hide resolved
docs/workbench-imagestreams.md Outdated Show resolved Hide resolved
docs/workbenches.md Outdated Show resolved Hide resolved
docs/workbenches.md Show resolved Hide resolved
docs/workbenches.md Outdated Show resolved Hide resolved
docs/workbenches.md Outdated Show resolved Hide resolved
docs/workbenches.md Outdated Show resolved Hide resolved
@atheo89 atheo89 force-pushed the docs branch 4 times, most recently from d0b53d1 to 1e8be17 Compare October 25, 2023 15:45
docs/workbenches.md Outdated Show resolved Hide resolved
@atheo89
Copy link
Member Author

atheo89 commented Oct 26, 2023

Thanks a lot, Jan for your attention to the details 🙂 I addressed all your comments!
Could you take a final review?

Copy link
Member

@jstourac jstourac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you Adriana! 🎉

@atheo89
Copy link
Member Author

atheo89 commented Oct 26, 2023

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 26, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: atheo89, jstourac

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot merged commit 033d462 into opendatahub-io:main Oct 26, 2023
1 check passed
@atheo89 atheo89 deleted the docs branch October 23, 2024 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants