Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wip] chores: Update the runtime image with the commit: 964ff92 #278

Closed

Conversation

harshad16
Copy link
Member

chores: Update the runtime image with the commit: 964ff92

Description

Updated the runtime image with the new changes in runtimes.
Related-to: #236

How Has This Been Tested?

NA

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@openshift-ci openshift-ci bot requested review from atheo89 and dibryant October 20, 2023 19:13
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 20, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from harshad16. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@harshad16 harshad16 changed the title chores: Update the runtime image with the commit: 964ff92 [wip] chores: Update the runtime image with the commit: 964ff92 Oct 20, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 20, 2023

@harshad16: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/notebook-cuda-jupyter-tf-ubi8-python-3-8-pr-image-mirror f654664 link true /test notebook-cuda-jupyter-tf-ubi8-python-3-8-pr-image-mirror
ci/prow/habana-notebooks-e2e-tests f654664 link true /test habana-notebooks-e2e-tests
ci/prow/notebooks-e2e-tests f654664 link true /test notebooks-e2e-tests
ci/prow/images f654664 link true /test images

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@atheo89
Copy link
Member

atheo89 commented Oct 26, 2023

Thanks, Harshard for opening this PR. I guess we need a revamp here, since we have pushed more commits from that time 964ff92. Currently, our latest builds stand at 34c3405 for the 2023b version and 17c2e49 for the 2023a version. Additionally, we will anticipate new commits today as will synchronize the main branch with the release branches.

@harshad16
Copy link
Member Author

Close this in favor of #286
thanks

@harshad16 harshad16 closed this Oct 26, 2023
harshad16 pushed a commit to harshad16/odh-notebooks that referenced this pull request Jun 28, 2024
Replace fcgi with supervisord on rstudio rhel flavor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants