-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix trustyai notebook test #274
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you, Diamond!
The test failed because it's pointing to the main branch of the tests. I though about this scenario few days ago already. We need to update links in our wget commands, something like this here. It's just a guess. I haven't time to investigate and test correct solution yet.
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: atheo89, jstourac The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/override notebooks-e2e-tests |
@atheo89: /override requires failed status contexts, check run or a prowjob name to operate on.
Only the following failed contexts/checkruns were expected:
If you are trying to override a checkrun that has a space in it, you must put a double quote on the context. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/override ci/prow/notebooks-e2e-tests |
@atheo89: Overrode contexts on behalf of atheo89: ci/prow/notebooks-e2e-tests In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Fixes for #192
Description
Fixing Error in ubi-9 versions of trustyai
How Has This Been Tested?
Merge criteria: