Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix trustyai notebook test #274

Merged
merged 1 commit into from
Oct 20, 2023
Merged

Conversation

dibryant
Copy link
Contributor

Fixes for #192

Description

Fixing Error in ubi-9 versions of trustyai

How Has This Been Tested?

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@openshift-ci openshift-ci bot requested review from atheo89 and harshad16 October 19, 2023 14:00
Copy link
Member

@jstourac jstourac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you, Diamond!

The test failed because it's pointing to the main branch of the tests. I though about this scenario few days ago already. We need to update links in our wget commands, something like this here. It's just a guess. I haven't time to investigate and test correct solution yet.

@atheo89
Copy link
Member

atheo89 commented Oct 20, 2023

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 20, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: atheo89, jstourac

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@atheo89
Copy link
Member

atheo89 commented Oct 20, 2023

/override notebooks-e2e-tests

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 20, 2023

@atheo89: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

  • notebooks-e2e-tests

Only the following failed contexts/checkruns were expected:

  • ci/prow/images
  • ci/prow/notebook-jupyter-trustyai-ubi9-python-3-9-pr-image-mirror
  • ci/prow/notebooks-e2e-tests
  • pull-ci-opendatahub-io-notebooks-2023a-images
  • pull-ci-opendatahub-io-notebooks-main-notebook-jupyter-trustyai-ubi9-python-3-9-pr-image-mirror
  • pull-ci-opendatahub-io-notebooks-main-notebooks-e2e-tests
  • tide

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to this:

/override notebooks-e2e-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@atheo89
Copy link
Member

atheo89 commented Oct 20, 2023

/override ci/prow/notebooks-e2e-tests

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 20, 2023

@atheo89: Overrode contexts on behalf of atheo89: ci/prow/notebooks-e2e-tests

In response to this:

/override ci/prow/notebooks-e2e-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot merged commit 05030d3 into opendatahub-io:main Oct 20, 2023
@atheo89 atheo89 changed the title Adding test for trustyai notebook Fix trustyai notebook test Oct 20, 2023
@atheo89 atheo89 mentioned this pull request Oct 20, 2023
@harshad16 harshad16 mentioned this pull request Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants