-
Notifications
You must be signed in to change notification settings - Fork 69
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat(deps): add kubeflow-training to workbench images
This commit adds `kubeflow-training[huggingface]` to the following workbench images: - `./jupyter/datascience/ubi9-python-3.11` - `./jupyter/pytorch/ubi9-python-3.11` - `./jupyter/rocm/pytorch/ubi9-python-3.11` - `./jupyter/trustyai/ubi9-python-3.11` - `./codeserver/ubi9-python-3.11` This outcome comes with a slew of caveats and disclaimers: - Due to a dependency conflict, `codeflare-sdk==0.24.3` was **also** added to the following workbench images. - `./jupyter/datascience/ubi9-python-3.11` - `./jupyter/pytorch/ubi9-python-3.11` - `./jupyter/rocm/pytorch/ubi9-python-3.11` - `./jupyter/trustyai/ubi9-python-3.11` -⚠️ In what may be a "controversial" decision, `codeflare-sdk` was **NOT** updated on other workbench images. Since `0.24.3` was a "one-off" release to unblock the `kubeflow-training` inclusion - the thought process here is that normal "sync" procedures on the next official release will standardize the `codeflare-sdk` dependency across all workbench images. This allows us to restrict the testing effort of this commit. - `jupyter/minmal/ubi9-python-3.11` was deliberately excluded from receiving `kubeflow-training` per discussions with team. - Due to dependency conflicts discovered `tensorflow`-based workbench images,`kubeflow-training` has not been added to those workbench images at this time. This decision was agreed to by affect stakeholders. Core blocking issue can be seen here: - onnx/tensorflow-onnx#2328 - Due to a dependency conflict, `transformers = "==4.38.0"` was **also** added to the`./jupyter/trustyai/ubi9-python-3.11` workbench image after discussion with the developer that last worked on the `trustyai` image. While it certainly must be tested, there was no strict requirement that necessitated pinning the `transformers` dependency to `4.36.2` - and the `huggingface` `extras` now introduces a `4.38.0` constraint for `transformers`. Related-to: https://issues.redhat.com/browse/RHOAIENG-12822
- Loading branch information
1 parent
2bd35f7
commit 70c151d
Showing
10 changed files
with
2,076 additions
and
18 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.