Skip to content

Commit

Permalink
feat(deps): add kubeflow-training to workbench images
Browse files Browse the repository at this point in the history
This commit adds `kubeflow-training[huggingface]` to the following workbench images:
- `./jupyter/datascience/ubi9-python-3.11`
- `./jupyter/pytorch/ubi9-python-3.11`
- `./jupyter/rocm/pytorch/ubi9-python-3.11`
- `./jupyter/trustyai/ubi9-python-3.11`
- `./codeserver/ubi9-python-3.11`

This outcome comes with a slew of caveats and disclaimers:
- Due to a dependency conflict, `codeflare-sdk==0.24.3` was **also** added to the following workbench images.
    - `./jupyter/datascience/ubi9-python-3.11`
    - `./jupyter/pytorch/ubi9-python-3.11`
    - `./jupyter/rocm/pytorch/ubi9-python-3.11`
    - `./jupyter/trustyai/ubi9-python-3.11`
- ⚠️ In what may be a "controversial" decision, `codeflare-sdk` was **NOT** updated on other workbench images.  Since `0.24.3` was a "one-off" release to unblock the `kubeflow-training` inclusion - the thought process here is that normal "sync" procedures on the next official release will standardize the `codeflare-sdk` dependency across all workbench images.  This allows us to restrict the testing effort of this commit.
- `jupyter/minmal/ubi9-python-3.11` was deliberately excluded from receiving `kubeflow-training` per discussions with team.
- Due to dependency conflicts discovered `tensorflow`-based workbench images,`kubeflow-training` has not been added to those workbench images at this time.  This decision was agreed to by affect stakeholders.  Core blocking issue can be seen here:
    - onnx/tensorflow-onnx#2328
- Due to a dependency conflict, `transformers = "==4.38.0"` was **also** added to the`./jupyter/trustyai/ubi9-python-3.11` workbench image after discussion with the developer that last worked on the `trustyai` image.  While it certainly must be tested, there was no strict requirement that necessitated pinning the `transformers` dependency to `4.36.2` - and the `huggingface` `extras` now introduces a `4.38.0` constraint for `transformers`.

Related-to: https://issues.redhat.com/browse/RHOAIENG-12822
  • Loading branch information
andyatmiami committed Dec 29, 2024
1 parent 2bd35f7 commit 70c151d
Show file tree
Hide file tree
Showing 10 changed files with 2,076 additions and 18 deletions.
3 changes: 2 additions & 1 deletion codeserver/ubi9-python-3.11/Pipfile
100644 → 100755
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,9 @@ scikit-learn = "~=1.4.0"
scipy = "~=1.12.0"
skl2onnx = "~=1.16.0"
ipykernel = "~=6.29.3"
kubeflow-training = {extras = ["huggingface"], version = "==1.8.1"}

# Some extra usefull packages
# Some extra useful packages
opencensus = "~=0.11.4"
smart-open = "~=7.0.1"
virtualenv = "~=20.25.1"
Expand Down
741 changes: 736 additions & 5 deletions codeserver/ubi9-python-3.11/Pipfile.lock

Large diffs are not rendered by default.

3 changes: 2 additions & 1 deletion jupyter/datascience/ubi9-python-3.11/Pipfile
100644 → 100755
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,8 @@ scikit-learn = "~=1.5.1"
scipy = "~=1.14.1"
skl2onnx = "~=1.17.0"
onnxconverter-common = "~=1.13.0" # Required for skl2onnx, as upgraded version is not compatible with protobuf
codeflare-sdk = "~=0.24.0"
codeflare-sdk = "==0.24.3"
kubeflow-training = {extras = ["huggingface"], version = "==1.8.1"}

# DB connectors
pymongo = "~=4.8.0"
Expand Down
537 changes: 536 additions & 1 deletion jupyter/datascience/ubi9-python-3.11/Pipfile.lock

Large diffs are not rendered by default.

3 changes: 2 additions & 1 deletion jupyter/pytorch/ubi9-python-3.11/Pipfile
100644 → 100755
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,8 @@ scikit-learn = "~=1.5.1"
scipy = "~=1.14.1"
skl2onnx = "~=1.17.0"
onnxconverter-common = "~=1.13.0" # Required for skl2onnx, as upgraded version is not compatible with protobuf
codeflare-sdk = "~=0.24.0"
codeflare-sdk = "==0.24.3"
kubeflow-training = {extras = ["huggingface"], version = "==1.8.1"}

# DB connectors
pymongo = "~=4.8.0"
Expand Down
383 changes: 382 additions & 1 deletion jupyter/pytorch/ubi9-python-3.11/Pipfile.lock

Large diffs are not rendered by default.

3 changes: 2 additions & 1 deletion jupyter/rocm/pytorch/ubi9-python-3.11/Pipfile
100644 → 100755
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,8 @@ scikit-learn = "~=1.5.1"
scipy = "~=1.14.1"
skl2onnx = "~=1.17.0"
onnxconverter-common = "~=1.13.0" # Required for skl2onnx, as upgraded version is not compatible with protobuf
codeflare-sdk = "~=0.24.0"
codeflare-sdk = "==0.24.3"
kubeflow-training = {extras = ["huggingface"], version = "==1.8.1"}

# DB connectors
pymongo = "~=4.8.0"
Expand Down
383 changes: 382 additions & 1 deletion jupyter/rocm/pytorch/ubi9-python-3.11/Pipfile.lock

Large diffs are not rendered by default.

5 changes: 3 additions & 2 deletions jupyter/trustyai/ubi9-python-3.11/Pipfile
100644 → 100755
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ name = "pytorch"
# PyTorch packages
torch = {version = "~=2.2.1", index = "pytorch"}
# TrustyAI packages
transformers = "~=4.36.2"
transformers = "~=4.38.0"
datasets = "~=2.21.0"
accelerate = "~=0.34.2"
trustyai = "~=0.6.1"
Expand All @@ -30,7 +30,8 @@ scikit-learn = "~=1.2.1" # Should be pinned down to this version in order to be
scipy = "~=1.14.1"
skl2onnx = "~=1.17.0"
onnxconverter-common = "~=1.13.0" # Required for skl2onnx, as upgraded version is not compatible with protobuf
codeflare-sdk = "~=0.24.0"
codeflare-sdk = "==0.24.3"
kubeflow-training = {extras = ["huggingface"], version = "==1.8.1"}

# DB connectors
pymongo = "~=4.8.0"
Expand Down
33 changes: 29 additions & 4 deletions jupyter/trustyai/ubi9-python-3.11/Pipfile.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 70c151d

Please sign in to comment.