Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UPSTREAM: 11480: chore(backend): Fixed namespace in job creation #122

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

hbelmiro
Copy link

@hbelmiro hbelmiro commented Jan 9, 2025

Cherry-pick from kubeflow#11480

Checklist:

Signed-off-by: Helber Belmiro <[email protected]>

(cherry picked from commit 72f11d9)
Signed-off-by: Helber Belmiro <[email protected]>
Copy link

openshift-ci bot commented Jan 9, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign rimolive for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dsp-developers
Copy link

Commit Checker results:

**NOTE**: These are the results of the commit checker scans. 
If these are not commits from upstream kfp, then please ensure
you adhere to the commit checker formatting
commitchecker verson unknown
Validating 1 commits between 2969fcac9a590bc26c59ca95a9ed8eacc514b6a3...34bf2f8d6b5b2f35fb3e6ff641e6bda09cb4a24e

@dsp-developers
Copy link

A set of new images have been built to help with testing out this PR:
API Server: quay.io/opendatahub/ds-pipelines-api-server:pr-122
DSP DRIVER: quay.io/opendatahub/ds-pipelines-driver:pr-122
DSP LAUNCHER: quay.io/opendatahub/ds-pipelines-launcher:pr-122
Persistence Agent: quay.io/opendatahub/ds-pipelines-persistenceagent:pr-122
Scheduled Workflow Manager: quay.io/opendatahub/ds-pipelines-scheduledworkflow:pr-122
MLMD Server: quay.io/opendatahub/mlmd-grpc-server:latest
MLMD Envoy Proxy: registry.redhat.io/openshift-service-mesh/proxyv2-rhel8:2.3.9-2
UI: quay.io/opendatahub/ds-pipelines-frontend:pr-122

@dsp-developers
Copy link

An OCP cluster where you are logged in as cluster admin is required.

The Data Science Pipelines team recommends testing this using the Data Science Pipelines Operator. Check here for more information on using the DSPO.

To use and deploy a DSP stack with these images (assuming the DSPO is deployed), first save the following YAML to a file named dspa.pr-122.yaml:

apiVersion: datasciencepipelinesapplications.opendatahub.io/v1alpha1
kind: DataSciencePipelinesApplication
metadata:
  name: pr-122
spec:
  dspVersion: v2
  apiServer:
    image: "quay.io/opendatahub/ds-pipelines-api-server:pr-122"
    argoDriverImage: "quay.io/opendatahub/ds-pipelines-driver:pr-122"
    argoLauncherImage: "quay.io/opendatahub/ds-pipelines-launcher:pr-122"
  persistenceAgent:
    image: "quay.io/opendatahub/ds-pipelines-persistenceagent:pr-122"
  scheduledWorkflow:
    image: "quay.io/opendatahub/ds-pipelines-scheduledworkflow:pr-122"
  mlmd:  
    deploy: true  # Optional component
    grpc:
      image: "quay.io/opendatahub/mlmd-grpc-server:latest"
    envoy:
      image: "registry.redhat.io/openshift-service-mesh/proxyv2-rhel8:2.3.9-2"
  mlpipelineUI:
    deploy: true  # Optional component 
    image: "quay.io/opendatahub/ds-pipelines-frontend:pr-122"
  objectStorage:
    minio:
      deploy: true
      image: 'quay.io/opendatahub/minio:RELEASE.2019-08-14T20-37-41Z-license-compliance'

Then run the following:

cd $(mktemp -d)
git clone [email protected]:opendatahub-io/data-science-pipelines.git
cd data-science-pipelines/
git fetch origin pull/122/head
git checkout -b pullrequest 34bf2f8d6b5b2f35fb3e6ff641e6bda09cb4a24e
oc apply -f dspa.pr-122.yaml

More instructions here on how to deploy and test a Data Science Pipelines Application.

@hbelmiro hbelmiro marked this pull request as ready for review January 9, 2025 12:41
@openshift-ci openshift-ci bot requested review from gmfrasca and rimolive January 9, 2025 12:41
@hbelmiro hbelmiro marked this pull request as draft January 9, 2025 12:41
@hbelmiro hbelmiro marked this pull request as ready for review January 9, 2025 14:12
@hbelmiro hbelmiro marked this pull request as draft January 9, 2025 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants