Display publisher as multilang #339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefina
requested changes
Dec 20, 2024
bellisk
reviewed
Dec 20, 2024
Comment on lines
352
to
353
| elif isinstance(data.get(key), dict): | ||
| data[key] = json.dumps(data.get(key)) |
There was a problem hiding this comment.
Building on what @stefina said above, I think you can move this case to the start of the function and remove one level of the nesting of the logic. :)
bellisk
approved these changes
Dec 20, 2024
bellisk
reviewed
Dec 20, 2024
| if isinstance(data.get(key), dict): | ||
| data[key] = json.dumps(data.get(key)) | ||
| return # exit early since this case is handled | ||
| # the key is missing | ||
| if not data.get(key): |
There was a problem hiding this comment.
I think you can remove this if statement and un-indent everything beneath it by one tab
There was a problem hiding this comment.
I would not do this, actually I would remove
if isinstance(data.get(key), dict):
data[key] = json.dumps(data.get(key))
return
And really validate the missing value here. If we will remove if not data.get(key)
It could lead to overwriting valid data, like str value (from foaf:Organization).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.