Allow escaping labels and property keys for TCK Cypher Value Parser #317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mats-SX
requested changes
Jul 26, 2018
There was a problem hiding this comment.
Is the point simply to allow wrapping backticks, or to extend the support of these symbols to be able to contain whitespace? If the former; no additional comments, if the latter: there should be tests for whitespace-containing labels, properties and rel-types.
| test("relationship") { | ||
| val string = "[:A {since: 1920}]" | ||
| val parsed = CypherValue(string) | ||
| val expected = CypherRelationship("A", CypherPropertyMap(Map("since" -> CypherInteger(1920)))) | ||
| parsed should equal(expected) | ||
| } | ||
|
|
||
| test("relationship with escaped label") { |
|
|
||
| relationshipTypeName : SYMBOLIC_NAME ; | ||
|
|
||
| label : ':' labelName ; | ||
| label : ':' (labelName | ('`' labelName '`')) ; |
There was a problem hiding this comment.
Since all these three rules resolve to the same lexer rule SYMBOLIC_NAME, perhaps we could simplify the change by introducing an in-between parser rule symbolicName that allows escaping?
Like
propertyKey: symbolicName ;
relationshipTypeName: symbolicName ;
labelName: symbolicName ;
symbolicName: '`' SYMBOLIC_NAME '`' ;
|
@DarthMax Is this still something we need? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.