-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
C++ Demo for person_reid_youtureid #277
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for contributions 👍 Please have a look at the comments below.
find_package(OpenCV ${OPENCV_VERSION} REQUIRED HINTS ${OPENCV_INSTALLATION_PATH}) | ||
|
||
add_executable(demo demo.cpp) | ||
target_link_libraries(demo ${OpenCV_LIBS} stdc++fs) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why "stdc++fs" is needed here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is because we previously used the filesystem library. We have now made changes and replaced it with OpenCV's built-in method. Now, we only need to use target_link_libraries(demo ${OpenCV_LIBS}).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM👍
Details
This pull request adds a C++ demo for the person_reid_youtureid requested in #135
README.md
was updated to include basic instructions for compiling and running the C++ demo.CMakeLists.txt
contains the cmake code necessary for building the C++ demo.demo.cpp
contains the source code for the C++ demo.Tests
(test data comes from https://github.com/ReID-Team/ReID_extra_testdata)