Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C++ Demo for person_reid_youtureid #277

Merged
merged 4 commits into from
Nov 15, 2024
Merged

Conversation

redhecker
Copy link
Contributor

@redhecker redhecker commented Nov 14, 2024

Details

This pull request adds a C++ demo for the person_reid_youtureid requested in #135

  • README.md was updated to include basic instructions for compiling and running the C++ demo.
  • CMakeLists.txt contains the cmake code necessary for building the C++ demo.
  • demo.cpp contains the source code for the C++ demo.

Tests

8f21790116b814d59d165c88affdbe0
c3a2d615895f66d46781c129dcb2f1d
dd902b92b68a6ce807964d1ea73e1c7
(test data comes from https://github.com/ReID-Team/ReID_extra_testdata)

Copy link
Member

@fengyuentau fengyuentau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contributions 👍 Please have a look at the comments below.

models/person_reid_youtureid/CMakeLists.txt Outdated Show resolved Hide resolved
find_package(OpenCV ${OPENCV_VERSION} REQUIRED HINTS ${OPENCV_INSTALLATION_PATH})

add_executable(demo demo.cpp)
target_link_libraries(demo ${OpenCV_LIBS} stdc++fs)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why "stdc++fs" is needed here?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is because we previously used the filesystem library. We have now made changes and replaced it with OpenCV's built-in method. Now, we only need to use target_link_libraries(demo ${OpenCV_LIBS}).

Copy link
Member

@fengyuentau fengyuentau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM👍

@fengyuentau fengyuentau merged commit 807f45b into opencv:main Nov 15, 2024
@redhecker redhecker deleted the pre_pr branch November 16, 2024 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants