-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix spelling, spacing, and unused variables #236
Conversation
Additional note: While I did not implement this change, I observed that the following was declared but unused in the C++ demos.
|
@@ -237,10 +237,9 @@ int main(int argc, char** argv) | |||
backendTargetPairs[backendTargetid].first, backendTargetPairs[backendTargetid].second); | |||
//! [Open a video file or an image file or a camera stream] | |||
if (!cap.isOpened()) | |||
CV_Error(Error::StsError, "Cannot opend video or file"); | |||
CV_Error(Error::StsError, "Cannot video or file"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
open
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed! Also updated several more typos.
Which particular demo? |
Models with that unused function:
Most of them define it in the class, but end up using the following in the constructor:
In the Python equivalent classes and |
Well, you are right. They are used for benchmark in Python scripts but we don't need them in C++ demos. It's okay to remove them then. |
@fengyuentau I've removed all such instances of unused |
Thank you for your contritbution 👍 |
Minor PR fixing spelling mistakes, spacing, and removed unused variables. Issue partially mentioned in #135 (comment).